-
Notifications
You must be signed in to change notification settings - Fork 5
Update Maven snapshot repository #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @brfrn169, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the Maven snapshot repository URL used by the scalardb and scalardl projects. This change is necessary to reflect a recent switch in the snapshot repository used for uploading SNAPSHOT versions, ensuring that both projects correctly resolve their dependencies from the new location.
Highlights
- Repository Update: The Maven snapshot repository URL has been updated from
https://oss.sonatype.org/content/repositories/snapshots/tohttps://central.sonatype.com/repository/maven-snapshots/. - Project Alignment: This change aligns the repository configuration across
scalardbandscalardlprojects with recent updates made in related repositories (ScalarDL PR #194 and ScalarDB PR #2849).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the Maven snapshot repository URL in both scalardb/project.clj and scalardl/project.clj. My review includes suggestions to fix a minor typo in the repository alias in both files, which will improve code clarity and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Maven snapshot repository reference used for deploying SNAPSHOT versions in both ScalarDL and ScalarDB.
- Updated the snapshot repository URL in scalardl/project.clj
- Updated the snapshot repository URL in scalardb/project.clj
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scalardl/project.clj | Changed snapshot repository URL to central.sonatype.com |
| scalardb/project.clj | Changed snapshot repository URL to central.sonatype.com |
Comments suppressed due to low confidence (4)
scalardl/project.clj:15
- [nitpick] The repository alias "sonartype" appears to be a typo; consider renaming it to "sonatype" for clarity and consistency.
:repositories {"sonartype" "https://central.sonatype.com/repository/maven-snapshots/"}
scalardb/project.clj:14
- [nitpick] The repository alias "sonartype" appears to be a typo; consider renaming it to "sonatype" for clarity and consistency.
:repositories {"sonartype" "https://central.sonatype.com/repository/maven-snapshots/"}
scalardl/project.clj:15
- The snapshot repository definition is duplicated across modules; consider extracting this configuration into a shared parent or profile to reduce duplication.
:repositories {"sonartype" "https://central.sonatype.com/repository/maven-snapshots/"}
scalardb/project.clj:14
- The snapshot repository definition is duplicated; extracting common settings into a parent project or shared config could improve maintainability.
:repositories {"sonartype" "https://central.sonatype.com/repository/maven-snapshots/"}
jnmt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
yito88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Since we switched the snapshot repository used for uploading SNAPSHOT versions in ScalarDL (scalar-labs/scalardl#194) and ScalarDB (scalar-labs/scalardb#2849), we should also update the repository reference accordingly. This PR addresses that.
Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A