Add sample application for ScalarDB Cluster .NET Client SDK (SQL) #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dima-X
requested review from
a team,
Torch3333,
brfrn169,
feeblefakie and
komamitsu
and removed request for
a team
komamitsu
reviewed
Apr 4, 2025
|
|
||
| await Task.Delay(TimeSpan.FromSeconds(1)); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think an error handling for retry-over is needed.
Contributor
There was a problem hiding this comment.
An exception should be thrown when the retry is over. Without any exception, users won't know what is happening when facing failures in the following commands.
Contributor
|
@feeblefakie @brfrn169 @Torch3333 I added a small fix to throw the last exception when the retry is over 0e7cd46. PTAL just in case. |
Contributor
|
@komamitsu Thank you! 🙇 |
feeblefakie
approved these changes
Apr 4, 2025
kota2and3kan
approved these changes
Apr 7, 2025
Contributor
kota2and3kan
left a comment
kota2and3kan
left a comment
There was a problem hiding this comment.
LGTM! Thank you!
FYI: I was able to run this sample application in my local environment.
$ dotnet run PlaceOrder 1 3:1,4:1
{
"order_id": "39bf2d74-e5ef-423a-a278-56148527993b"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds sample application for ScalarDB Cluster .NET Client SDK that uses
ISqlTransactionManager.This is a SQL version of #77
Related issues and/or PRs
https://github.com/scalar-labs/docs-internal-scalardb/pull/1061
Changes made
scalardb-dotnet-samples/scalardb-cluster-sql-sample.gitignoreChecklist
Additional notes (optional)