Skip to content

Conversation

@KodaiD
Copy link
Contributor

@KodaiD KodaiD commented Nov 26, 2025

Description

This PR adds setup for Blob Storage in the standalone mode sample.

Related issues and/or PRs

Changes made

  • Added Blob Storage setup to the standalone mode sample.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@KodaiD KodaiD self-assigned this Nov 26, 2025
@KodaiD
Copy link
Contributor Author

KodaiD commented Nov 26, 2025

Since scalardb-sample and scalardb-kotlin-sample use the secondary index feature, and the Object Storage adapter does not support it, we cannot run those samples with Object Storage.

@KodaiD KodaiD marked this pull request as ready for review November 26, 2025 14:08
Copilot AI review requested due to automatic review settings November 26, 2025 14:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot finished reviewing on behalf of KodaiD November 26, 2025 14:34
@KodaiD KodaiD requested review from a team, Torch3333, brfrn169, Copilot, feeblefakie and komamitsu and removed request for a team November 26, 2025 23:25
Copilot finished reviewing on behalf of KodaiD November 26, 2025 23:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KodaiD
Copy link
Contributor Author

KodaiD commented Nov 26, 2025

I verified the setting in my local environment:

❯ docker compose up -d blobstorage               
[+] Running 2/2
 ✔ Network scalardb-cluster-standalone-mode_default  Created                                                                                                                                                                                                                                                  0.0s 
 ✔ Container blobstorage-1                           Started                                                                                                                                                                                                                                                  0.2s 

❯ docker compose up blobstorage-container-creator
[+] Running 2/2
 ✔ Container blobstorage-1                  Running                                                                                                                                                                                                                                                           0.0s 
 ✔ Container blobstorage-container-creator  Created                                                                                                                                                                                                                                                           0.0s 
Attaching to blobstorage-container-creator
blobstorage-container-creator  | {
blobstorage-container-creator  |   "created": true
blobstorage-container-creator  | }
blobstorage-container-creator exited with code 0

❯ docker compose up -d scalardb-cluster-node
[+] Running 2/2
 ✔ Container scalardb-cluster-node                                                                                                                                      Started                                                                                                                               0.1s 
 ! scalardb-cluster-node The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested                                                                                                                                       0.0s 

❯ java -jar scalardb-cluster-sql-cli-3.16.1-all.jar -c scalardb-cluster-sql-cli.properties
[main] INFO com.scalar.db.cluster.common.ConsistentHashingDistribution - Refreshed the ring for [localhost]
[main] INFO com.scalar.db.cluster.common.ConsistentHashingDistribution - Refreshed the ring for [localhost]
sqlline version 1.12.0
0: scalardb> create coordinator tables;
No rows affected (1.019 seconds)
0: scalardb>

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants