Additional updates for Analytics 3.17

[reddikih]

Description

This PR adjusts the scalardb-analytics-sample to work properly with ScalarDB Analytics 3.17. The changes address compatibility requirements for the updated Analytics version.

Related issues and/or PRs

• Related to PR Support ScalarDB Analytics 3.17 #82 which added support for ScalarDB Analytics 3.17.

Changes made

• Updated Spark version from 3.5.6 to 3.5.7 in docker/Dockerfile.spark
  • Spark version 3.5.6 is no longer available.
• Modified sql/postgres_copy.sql to use schema-qualified table names:
  • Added create schema if not exists sample_ns; statement
  • Changed table creation from customer to sample_ns.customer
  • Updated \copy command to reference sample_ns.customer

Checklist

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

[gemini-code-assist]

Summary of Changes

Hello @reddikih, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures the scalardb-analytics-sample application remains compatible with ScalarDB Analytics 3.17. It addresses necessary adjustments, including updating the Spark version and modifying SQL scripts to use schema-qualified table names, to maintain functionality with the updated analytics platform.

Highlights

• Spark Version Update: The Spark version in docker/Dockerfile.spark has been updated from 3.5.6 to 3.5.7 to address the unavailability of the older version.
• Schema-Qualified Table Names: The sql/postgres_copy.sql script was modified to create a sample_ns schema and use schema-qualified names for the customer table and the \copy command, ensuring proper operation with ScalarDB Analytics 3.17.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request makes necessary adjustments for compatibility with ScalarDB Analytics 3.17, including updating the Spark version and adding a schema to the PostgreSQL setup. The changes are logical and well-explained. I have one suggestion for the SQL script to improve data loading performance by using the COPY command, which is a best practice for bulk inserts in PostgreSQL.

[feeblefakie]

LGTM! Thank you!

[choplin]

LGTM!

[brfrn169]

LGTM! Thank you!

[komamitsu]

LGTM! 👍