Backport to branch(3.12) : Add import command for data loader CLI #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Peckstadt Yves <[email protected]> Co-authored-by: Toshihiro Suzuki <[email protected]>
Contributor
|
@brfrn169 san, |
brfrn169
reviewed
May 28, 2025
| File configFile = new File(configFilePath); | ||
| StorageFactory storageFactory = StorageFactory.create(configFile); | ||
| try (DistributedStorageAdmin storageAdmin = storageFactory.getStorageAdmin()) { | ||
| DistributedStorageAdmin storageAdmin = null; |
Collaborator
There was a problem hiding this comment.
@inv-jishnu Sorry, why do we need this change only for the 3.12 branch?
Contributor
There was a problem hiding this comment.
@brfrn169 san,
As I mentioned above there was a CI failure
> Task :data-loader:cli:compileJava FAILED
/home/runner/work/scalardb/scalardb/data-loader/cli/src/main/java/com/scalar/db/dataloader/cli/command/dataimport/ImportCommand.java:99: error: incompatible types: try-with-resources not applicable to variable type
try (DistributedStorageAdmin storageAdmin = storageFactory.getStorageAdmin()) {
^
(DistributedStorageAdmin cannot be converted to AutoCloseable)
Note: /home/runner/work/scalardb/scalardb/data-loader/cli/src/main/java/com/scalar/db/dataloader/cli/command/dataexport/ScanOrderingConverter.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
I thought there may have been an update in DistributedStorageAdmin implementation. This only happened in 3.12 branch. Hence I changed the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of the following:
Please merge this PR after all checks have passed.