-
Notifications
You must be signed in to change notification settings - Fork 40
Fix typo #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a typographical error in the exception and API documentation comments by replacing “nontranient” with “nontransient.”
- Corrected the spelling of “nontransient” in exception class comments.
- Updated API documentation comments in multiple interfaces.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/main/java/com/scalar/db/exception/transaction/ValidationException.java | Corrected typo in the exception documentation comment. |
| core/src/main/java/com/scalar/db/exception/transaction/PreparationException.java | Corrected typo in the exception documentation comment. |
| core/src/main/java/com/scalar/db/exception/transaction/CrudException.java | Corrected typo in the exception documentation comment. |
| core/src/main/java/com/scalar/db/exception/transaction/CommitException.java | Corrected typo in the exception documentation comment. |
| core/src/main/java/com/scalar/db/api/TwoPhaseCommitTransactionManager.java | Corrected typo in the API documentation comment. |
| core/src/main/java/com/scalar/db/api/TwoPhaseCommitTransaction.java | Corrected typos in multiple documentation comment lines. |
| core/src/main/java/com/scalar/db/api/TransactionManagerCrudOperable.java | Corrected typos in multiple documentation comment lines. |
| core/src/main/java/com/scalar/db/api/TransactionCrudOperable.java | Corrected typos in multiple documentation comment lines. |
| core/src/main/java/com/scalar/db/api/DistributedTransaction.java | Corrected typo in the API documentation comment. |
| * An exception thrown when validating a transaction fails due to transient or nontransient faults. | ||
| * You can try retrying the transaction from the beginning, but the transaction may still fail if | ||
| * the cause is nontranient. | ||
| * the cause is nontransient. |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo corrected: 'nontranient' has been updated to 'nontransient' for clarity in the documentation comment.
| * An exception thrown when preparing a transaction fails due to transient or nontransient faults. | ||
| * You can try retrying the transaction from the beginning, but the transaction may still fail if | ||
| * the cause is nontranient. | ||
| * the cause is nontransient. |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo corrected: 'nontranient' has been updated to 'nontransient' for clarity in the documentation comment.
| * An exception thrown when a transaction CRUD operation fails due to transient or nontransient | ||
| * faults. You can try retrying the transaction from the beginning, but the transaction may still | ||
| * fail if the cause is nontranient. | ||
| * fail if the cause is nontransient. |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo corrected: 'nontranient' has been updated to 'nontransient' in the exception documentation comment.
| * An exception thrown when committing a transaction fails due to transient or nontransient faults. | ||
| * You can try retrying the transaction from the beginning, but the transaction may still fail if | ||
| * the cause is nontranient. | ||
| * the cause is nontransient. |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo corrected: 'nontranient' has been updated to 'nontransient' in the exception documentation comment.
| * @throws TransactionException if joining the transaction fails due to transient or nontransient | ||
| * faults. You can try retrying the transaction from the beginning, but the transaction may | ||
| * still fail if the cause is nontranient | ||
| * still fail if the cause is nontransient |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo corrected: 'nontranient' has been updated to 'nontransient' for clarity in the API comment.
| * @throws PreparationException if the transaction fails to prepare due to transient or | ||
| * nontransient faults. You can try retrying the transaction from the beginning, but the | ||
| * transaction may still fail if the cause is nontranient | ||
| * transaction may still fail if the cause is nontransient |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo corrected: 'nontranient' has been updated to 'nontransient' in the documentation comment (additional similar corrections exist in this file).
| * @throws CrudException if the transaction CRUD operation fails due to transient or nontransient | ||
| * faults. You can try retrying the transaction from the beginning, but the transaction may | ||
| * still fail if the cause is nontranient | ||
| * still fail if the cause is nontransient |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple occurrences of the typo 'nontranient' have been corrected to 'nontransient' in this file.
| * @throws CrudException if the transaction CRUD operation fails due to transient or nontransient | ||
| * faults. You can try retrying the transaction from the beginning, but the transaction may | ||
| * still fail if the cause is nontranient | ||
| * still fail if the cause is nontransient |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple occurrences of the typo 'nontranient' have been corrected to 'nontransient' in this file.
| * @throws CommitException if the transaction fails to commit due to transient or nontransient | ||
| * faults. You can try retrying the transaction from the beginning, but the transaction may | ||
| * still fail if the cause is nontranient | ||
| * still fail if the cause is nontransient |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo corrected: 'nontranient' has been updated to 'nontransient' for clarity in the documentation comment.
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Description
This PR fixes typo.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A