Create and publish snapshot version of data loader core #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypeckstadt
requested review from
a team,
Torch3333,
brfrn169,
Copilot,
feeblefakie,
komamitsu and
ypeckstadt
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Gradle configuration changes to enable publishing a snapshot version of the data loader core to the Sonatype repository.
- Adds Maven publishing, signing, and publication configuration to the data-loader/core/build.gradle file.
- Updates the release-snapshot workflow to include scalardb-data-loader-core in the snapshot upload step.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| data-loader/core/build.gradle | Adds Maven publishing, signing, and conditional disabling of the shadowJar for publish tasks. |
| .github/workflows/release-snapshot.yaml | Updates the workflow name to include scalardb-data-loader-core in the snapshot upload step. |
Comments suppressed due to low confidence (1)
data-loader/core/build.gradle:57
- The artifactId 'scalardb-data-loader' is inconsistent with the archivesBaseName 'scalardb-data-loader-core'. Consider aligning them for clarity in published artifacts.
artifactId = 'scalardb-data-loader'
Comment on lines
+48
to
+49
| if (project.gradle.startParameter.taskNames.any { it.endsWith('publish') } || | ||
| project.gradle.startParameter.taskNames.any { it.endsWith('publishToMavenLocal') }) { |
There was a problem hiding this comment.
[nitpick] Using broad string matching to detect publish tasks for disabling shadowJar might be fragile; consider checking for explicit task names to avoid unintended side effects.
Suggested change
| if (project.gradle.startParameter.taskNames.any { it.endsWith('publish') } || | |
| project.gradle.startParameter.taskNames.any { it.endsWith('publishToMavenLocal') }) { | |
| if (project.gradle.taskGraph.hasTask(":publish") || | |
| project.gradle.taskGraph.hasTask(":publishToMavenLocal")) { |
brfrn169
reviewed
Jun 5, 2025
| echo "version=${VERSION}" >> $GITHUB_OUTPUT | ||
| - name: Upload SNAPSHOT versions for scalardb, scalardb-schema-loader, and scalardb-integration-test to Maven Snapshot Repository | ||
| - name: Upload SNAPSHOT versions for scalardb, scalardb-schema-loader, scalardb-data-loader-core, and scalardb-integration-test to Maven Snapshot Repository |
Collaborator
There was a problem hiding this comment.
Could you please make the same change for the follows:
Contributor
Author
|
@brfrn169 san, |
brfrn169
reviewed
Jun 5, 2025
data-loader/core/build.gradle
Outdated
| from components.java | ||
| pom { | ||
| name = 'ScalarDB Data Loader' | ||
| description = 'A tool for importing data to and from ScalarDB' |
Collaborator
There was a problem hiding this comment.
Maybe exporting is necessary? (CC: @ypeckstadt, @josh-wong)
Suggested change
| description = 'A tool for importing data to and from ScalarDB' | |
| description = 'A tool for exporting data from and importing data into ScalarDB' |
Contributor
Author
There was a problem hiding this comment.
@brfrn169 san,
I have updated the description.
Thank you.
feeblefakie
pushed a commit
that referenced
this pull request
Jun 6, 2025
Co-authored-by: Peckstadt Yves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added changes to create and publish snap shot version of data loader core to sonatype repository.
This was added so that the data loader API can use the snapshot version in it.
Related issues and/or PRs
NA
Changes made
data loader corein comments for release-snapshot workflow which is used to create snapshot versions.Checklist
Additional notes (optional)
NA
Release notes
NA