Add --replication-tables option to the Schema Loader
#2747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komamitsu
requested review from
Torch3333,
brfrn169,
Copilot and
feeblefakie
and removed request for
Torch3333
komamitsu
changed the title
--replication-tables option--replication-tables option to the Schema Loader
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new option (--replication-tables) to manage replication-related tables. The changes update the schema loader command and related API methods to accept an additional boolean flag for replication tables, add corresponding tests, and update the replication administration interface.
- Added new boolean parameters and option handling for replication tables in SchemaLoader and SchemaOperator.
- Extended command-line tests to validate the new option in various table creation, deletion, and repair scenarios.
- Removed confusing default implementations in ReplicationAdmin to allow overwriting.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| schema-loader/src/test/java/com/scalar/db/schemaloader/command/SchemaLoaderCommandTest.java | Updated tests to include replication tables flag in command execution and verification. |
| schema-loader/src/test/java/com/scalar/db/schemaloader/SchemaOperatorTest.java | Added unit tests for replication table creation, dropping, and repair. |
| schema-loader/src/main/java/com/scalar/db/schemaloader/command/SchemaLoaderCommand.java | Modified command options and subsequent method calls to pass the replication tables flag. |
| schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaOperator.java | Introduced new methods for creating, dropping, and repairing replication tables. |
| schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaLoader.java | Overloaded several methods to accept an extra replication tables flag and updated documentation accordingly. |
| schema-loader/build.gradle | Added a new test dependency for parameterized tests. |
| core/src/main/java/com/scalar/db/api/ReplicationAdmin.java | Removed default implementations for replication tables, replacing them with exceptions. |
Comments suppressed due to low confidence (2)
schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaLoader.java:107
- [nitpick] Consider encapsulating the boolean flags for coordinator and replication table creation into a dedicated options object. This can improve readability and future extensibility of the API.
boolean createCoordinatorTables, boolean createReplicationTables)
core/src/main/java/com/scalar/db/api/ReplicationAdmin.java:33
- [nitpick] It may be beneficial to update the Javadoc or inline comments to clearly indicate that the replication feature is not enabled by default, explaining the rationale behind throwing an UnsupportedOperationException.
throw new UnsupportedOperationException(CoreError.REPLICATION_NOT_ENABLED.buildMessage());
komamitsu
commented
Jun 9, 2025
| */ | ||
| default void createReplicationTables(boolean ifNotExist, Map<String, String> options) | ||
| throws ExecutionException { | ||
| if (ifNotExist && replicationTablesExist()) { |
Contributor
Author
There was a problem hiding this comment.
Replaced confusing logics with simply throwing an exception.
brfrn169
approved these changes
Jun 10, 2025
Collaborator
brfrn169
left a comment
brfrn169
left a comment
There was a problem hiding this comment.
Left a comment. Other than that, LGTM! Thank you!
| return; | ||
| } | ||
| createReplicationTables(options); | ||
| throw new UnsupportedOperationException(CoreError.REPLICATION_NOT_ENABLED.buildMessage()); |
Collaborator
There was a problem hiding this comment.
Shouldn’t we revise the error message itself now that we’ve determined the license type?
komamitsu
added a commit
that referenced
this pull request
Jun 11, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
--replication-tablesoption to manage the replication related tables as well as--coordinatoroption for the coordinator tables. I first tried to add--replicationoption, but noticed--replication-factorexisted. So, I added--replication-tablesinstead.Related issues and/or PRs
None
Changes made
--replication-tablesoption.createReplicationTables(),dropReplicationTables()andrepairReplicationTables()toSchemaOperator.SchemaLoaderif--replication-tablesis specified.ReplicationAdmininterface since they can be easily overwritten.Checklist
Additional notes (optional)
None
Release notes
Added
replication-tablesoption to the Schema Loader.