-
Notifications
You must be signed in to change notification settings - Fork 40
Add Docker support for ScalarDB Data Loader CLI #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
c270cf5
9dcc0fc
db21c2a
cd6dbbb
004e597
fe52152
f5d5a8a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,8 +67,12 @@ jobs: | |
| run: | | ||
| mkdir -p /tmp/gradle_test_reports/core | ||
| mkdir -p /tmp/gradle_test_reports/schema-loader | ||
| mkdir -p /tmp/gradle_test_reports/data-loader/core | ||
| mkdir -p /tmp/gradle_test_reports/data-loader/cli | ||
| cp -a core/build/reports/tests/test /tmp/gradle_test_reports/core/ | ||
| cp -a schema-loader/build/reports/tests/test /tmp/gradle_test_reports/schema-loader/ | ||
| cp -a data-loader/core/build/reports/tests/test /tmp/gradle_test_reports/data-loader/core/ | ||
| cp -a data-loader/cli/build/reports/tests/test /tmp/gradle_test_reports/data-loader/cli/ | ||
|
|
||
| - name: Upload Gradle test reports | ||
| if: always() | ||
|
|
@@ -83,9 +87,13 @@ jobs: | |
| mkdir -p /tmp/gradle_spotbugs_reports/core | ||
| mkdir -p /tmp/gradle_spotbugs_reports/schema-loader | ||
| mkdir -p /tmp/gradle_spotbugs_reports/integration-test | ||
| mkdir -p /tmp/gradle_spotbugs_reports/data-loader/core | ||
| mkdir -p /tmp/gradle_spotbugs_reports/data-loader/cli | ||
| cp -a core/build/reports/spotbugs /tmp/gradle_spotbugs_reports/core/ | ||
| cp -a schema-loader/build/reports/spotbugs /tmp/gradle_spotbugs_reports/schema-loader/ | ||
| cp -a integration-test/build/reports/spotbugs /tmp/gradle_spotbugs_reports/integration-test/ | ||
| cp -a data-loader/core/build/reports/spotbugs /tmp/gradle_spotbugs_reports/data-loader/core/ | ||
| cp -a data-loader/cli/build/reports/spotbugs /tmp/gradle_spotbugs_reports/data-loader/cli/ | ||
|
|
||
| - name: Upload Spotbugs reports | ||
| if: always() | ||
|
|
@@ -113,6 +121,9 @@ jobs: | |
| - name: Dockerfile Lint for ScalarDB Schema Loader | ||
| run: ./gradlew schema-loader:dockerfileLint | ||
|
|
||
| - name: Dockerfile Lint for ScalarDB Data Loader CLI | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the same reason as the above. If required can still be all moved to a separate file though. |
||
| run: ./gradlew data-loader:cli:dockerfileLint | ||
|
|
||
| integration-test-for-cassandra-3-0: | ||
| name: Cassandra 3.0 integration test (${{ matrix.mode.label }}) | ||
| runs-on: ubuntu-latest | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,13 @@ | ||||||
| FROM eclipse-temurin:8-jre-jammy | ||||||
|
|
||||||
| RUN apt-get update && apt-get upgrade -y \ | ||||||
|
||||||
| RUN apt-get update && apt-get upgrade -y \ | |
| RUN apt-get update && apt-get upgrade -y --no-install-recommends \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I think we need to apply the same for the schema-loader image building. cc @brfrn169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added here and not in separate data loader ci file as it seems easier to manage in this file like this.