-
Notifications
You must be signed in to change notification settings - Fork 40
Add a dedicated CI workflow for data loader CLI #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1a8a8c7
Fix build error in data-loader
brfrn169 a0ba5e3
Added data loader build CI workflow
inv-jishnu 98d6f49
Minor change
inv-jishnu 640623e
Merge branch 'master' into data-loader/add-ci-for-build
inv-jishnu dd7d87f
Merge branch 'master' into data-loader/add-ci-for-build
inv-jishnu fe4761c
Apply suggestions from code review
ypeckstadt 0b40a16
Apply feedback
ypeckstadt 6aa5a34
Merge branch 'master' into data-loader/add-ci-for-build
inv-jishnu 6def419
Restore DirectoryUtilsTest changes
ypeckstadt b0549f6
Merge branch 'master' into data-loader/add-ci-for-build
inv-jishnu 30da066
Merge branch 'master' into data-loader/add-ci-for-build
inv-jishnu be8e0e2
Merge branch 'master' into data-loader/add-ci-for-build
inv-jishnu 1a64df6
Merge branch 'master' into data-loader/add-ci-for-build
inv-jishnu 0859ca6
Merge branch 'master' into data-loader/add-ci-for-build
brfrn169 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: CI for Data Loader CLI | ||
|
|
||
| on: | ||
| pull_request: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| data_loader_ci: | ||
| name: Build Data Loader CLI | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up JDK 8 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: 'temurin' | ||
| java-version: 8 | ||
|
|
||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v4 | ||
|
|
||
| - name: Gradle Data Loader CLI build | ||
| run: ./gradlew :data-loader:cli:build --no-daemon --stacktrace | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the cause of the test failure is still unclear, so I think we shouldn't merge this kind of ad-hoc workaround.
I ran
./gradlew :data-loader:cli:build --no-daemon --stacktracewithout this workaround with the latestdata-loader-ci.yaml, but it didn't failhttps://github.com/scalar-labs/scalardb/actions/runs/15702570827/job/44240661813. I guess the updated workflow file may have resolved the issue. Can you try without this workaround again just in case?
Even if it still fails, the unit tests should be already executed in
ci.yaml'scheckjob, so I think we can skip the unit tests indata-loader-ci.yamlby using./gradlew -x testlike./gradlew -x test :data-loader:cli:build.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inv-jishnu (If you missed this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@komamitsu san (cc @ypeckstadt ),
Sorry I missed this. You are right about the tests already executing in check job. And as I mentioned, since the test failure only occurs on my local environment with act, it might be some issue with my environment and we can ignore that.
Thank you for pointing this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change above was reverted by @ypeckstadt san in this commit 6def419.