Fix table creation with ifNotExists to include index creation in DynamoAdmin

[KodaiD]

Description

This PR fixes the table creation logic in the DynamoAdmin to create indexes when the table metadata includes them.

Currently, the table creation process with ifNotExists does not create indexes even if the table metadata specifies them. It can lead to inconsistencies between the actual table structure and its metadata.

To resolve this issue, this PR modifies the table creation logic to include index creation when the metadata specifies indexes.

Related issues and/or PRs

N/A

Changes made

• Update createTableInternal method in DynamoAdmin to include index creation when the table metadata specifies indexes.
• Extract the following methods to make it reusable:
  • createIndex
  • indexExists

Checklist

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[Copilot]

Pull Request Overview

This PR ensures that secondary indexes are created when a DynamoDB table already exists and ifNotExists is true in DynamoAdmin, and refactors index creation into reusable methods.

• Adds logic in createTableInternal to loop through and create missing secondary indexes.
• Extracts and overloads createIndex, moving table update and index-wait logic into a private method.
• Implements indexExists to check index presence and refactors waiting logic.

Comments suppressed due to low confidence (3)

core/src/main/java/com/scalar/db/storage/dynamo/DynamoAdmin.java:1037

• response.table().globalSecondaryIndexes() may be null when no global indexes are defined, causing a NullPointerException. Consider null-checking or defaulting to an empty list before iterating.

for (GlobalSecondaryIndexDescription globalSecondaryIndex : response.table().globalSecondaryIndexes()) {

core/src/main/java/com/scalar/db/storage/dynamo/DynamoAdmin.java:297

• The new index creation path when the table exists isn't covered by existing tests. Consider adding unit or integration tests for scenarios where ifNotExists is true and secondary indexes must be created.

} else if (!metadata.getSecondaryIndexNames().isEmpty()) {

core/src/main/java/com/scalar/db/storage/dynamo/DynamoAdmin.java:981

• [nitpick] Consider adding JavaDoc for this new overloaded createIndex method to clarify the role of each parameter, especially the ifNotExists flag, to improve readability and maintainability.

private void createIndex(Namespace namespace, String table, String columnName, DataType dataType, Long ru, boolean ifNotExists)

[KodaiD]

It will be better to solve the issue with another way. So I close this for now.