-
Notifications
You must be signed in to change notification settings - Fork 40
Rename methods of CommitHandler #2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames methods in the CommitHandler and related classes to align with the latest Consensus Commit documentation. The key changes include renaming from "prepare" to "prepareRecords" and "validate" to "validateRecords" across both production and test code, ensuring consistent method naming throughout the codebase.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| integration-test/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitSpecificIntegrationTestBase.java | Updated method calls to use the new prepareRecords method. |
| core/src/test/java/com/scalar/db/transaction/consensuscommit/TwoPhaseConsensusCommitTest.java | Renamed test methods and internal calls to match the new method names. |
| core/src/test/java/com/scalar/db/transaction/consensuscommit/ParallelExecutorTest.java | Updated test method names and calls to parallelExecutor to use prepareRecords and validateRecords. |
| core/src/main/java/com/scalar/db/transaction/consensuscommit/TwoPhaseConsensusCommit.java | Modified implementation to call prepareRecords and validateRecords. |
| core/src/main/java/com/scalar/db/transaction/consensuscommit/Snapshot.java | Changed validate call to validateRecords. |
| core/src/main/java/com/scalar/db/transaction/consensuscommit/ParallelExecutor.java | Updated method names for preparation and validation tasks. |
| core/src/main/java/com/scalar/db/transaction/consensuscommit/CommitHandler.java | Changed commit flow to use the new prepareRecords and validateRecords methods and removed redundant code. |
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
|
@Torch3333 I'll merge this. Please take a look when you have time! |
Description
This PR renames some methods of
CommitHandlerto align with the Consensus Commit documentation.Related issues and/or PRs
N/A
Changes made
CommitHandler.Checklist
Additional notes (optional)
N/A
Release notes
N/A