Remove before images after committing or rolling back records in Consensus Commit #2787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes before images after committing or rolling back records in Consensus Commit to reduce disk usage. Key changes include:
- Updating tests to use a builder pattern and additional before image columns.
- Refactoring both CommitMutationComposer and RollbackMutationComposer to set before image columns to null via a new helper method.
- Introducing a new static helper method in AbstractMutationComposer for setting null values for before image columns.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitMutationComposerTest.java | Updated test cases and expected mutations using the new builder pattern and additional before image columns. |
| core/src/main/java/com/scalar/db/transaction/consensuscommit/RollbackMutationComposer.java | Refactored mutation composition to use the new helper method and variables for retrieving table metadata. |
| core/src/main/java/com/scalar/db/transaction/consensuscommit/CommitMutationComposer.java | Updated commit mutation creation with the new builder pattern and before image column null-setting. |
| core/src/main/java/com/scalar/db/transaction/consensuscommit/AbstractMutationComposer.java | Added a new static helper to set null for before image columns based on data types. |
Comments suppressed due to low confidence (2)
core/src/main/java/com/scalar/db/transaction/consensuscommit/AbstractMutationComposer.java:45
- [nitpick] Consider adding JavaDoc comments for the setNullToBeforeImageColumns method to describe its purpose, behavior, and parameters, which would help maintainability and clarity.
TableMetadata tableMetadata) {
core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitMutationComposerTest.java:54
- [nitpick] Test constants like ANY_NAME_4 through ANY_NAME_13 might be made more descriptive to indicate their correspondence to specific before image columns, improving test readability.
private static final String ANY_NAME_4 = "name4";
brfrn169
force-pushed
the
remove-before-images-after-commit-or-rollback
branch
from
82348f2 to
3207eaa
Compare
brfrn169
commented
Jun 18, 2025
Comment on lines
+105
to
+113
| // Set before image columns to null | ||
| if (result != null) { | ||
| TransactionTableMetadata transactionTableMetadata = | ||
| tableMetadataManager.getTransactionTableMetadata(base); | ||
| LinkedHashSet<String> beforeImageColumnNames = | ||
| transactionTableMetadata.getBeforeImageColumnNames(); | ||
| TableMetadata tableMetadata = transactionTableMetadata.getTableMetadata(); | ||
| setBeforeImageColumnsToNull(putBuilder, beforeImageColumnNames, tableMetadata); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Added logic to set the before image columns to null.
Comment on lines
+121
to
+122
| // Set before image columns to null | ||
| setBeforeImageColumnsToNull(putBuilder, beforeImageColumnNames, tableMetadata); |
Collaborator
Author
There was a problem hiding this comment.
Ditto. Added logic to set the before image columns to null.
feeblefakie
pushed a commit
that referenced
this pull request
Jun 18, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the code to remove before images after committing or rolling back records in Consensus Commit to reduce disk usage.
Related issues and/or PRs
N/A
Changes made
CommitMutationComposerandRollbackMutationComposerto set the before image columns to null.Checklist
Additional notes (optional)
N/A
Release notes
Updated the code to remove before images after committing or rolling back records in Consensus Commit to reduce disk usage.