Optimize mutations based on the storage’s mutation atomicity unit in Consensus Commit #2807
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| package com.scalar.db.transaction.consensuscommit; | ||
|
|
||
| import com.scalar.db.api.Mutation; | ||
| import com.scalar.db.api.StorageInfo; | ||
| import com.scalar.db.common.StorageInfoProvider; | ||
| import com.scalar.db.exception.storage.ExecutionException; | ||
| import com.scalar.db.io.Key; | ||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.stream.Collectors; | ||
| import javax.annotation.Nullable; | ||
| import javax.annotation.concurrent.ThreadSafe; | ||
|
|
||
| @ThreadSafe | ||
| public class MutationsGrouper { | ||
|
Collaborator
Author
There was a problem hiding this comment. Added |
||
|
|
||
| private final StorageInfoProvider storageInfoProvider; | ||
|
|
||
| public MutationsGrouper(StorageInfoProvider storageInfoProvider) { | ||
| this.storageInfoProvider = storageInfoProvider; | ||
| } | ||
|
|
||
| public List<List<Mutation>> groupMutations(Collection<Mutation> mutations) | ||
| throws ExecutionException { | ||
| // MutationGroup mutations by their storage info and atomicity unit | ||
| List<MutationGroup> groups = new ArrayList<>(); | ||
|
||
| Map<MutationGroup, List<List<Mutation>>> groupToBatches = new LinkedHashMap<>(); | ||
|
|
||
| for (Mutation mutation : mutations) { | ||
| assert mutation.forNamespace().isPresent(); | ||
| StorageInfo storageInfo = storageInfoProvider.getStorageInfo(mutation.forNamespace().get()); | ||
brfrn169 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| MutationGroup matchedGroup = null; | ||
|
||
| for (MutationGroup group : groups) { | ||
| if (group.isSameGroup(mutation, storageInfo)) { | ||
| matchedGroup = group; | ||
| break; | ||
| } | ||
| } | ||
| if (matchedGroup == null) { | ||
| // If no matching group is found, create a new one | ||
| matchedGroup = new MutationGroup(mutation, storageInfo); | ||
| groups.add(matchedGroup); | ||
| } | ||
|
|
||
| List<List<Mutation>> batches = | ||
| groupToBatches.computeIfAbsent(matchedGroup, g -> new ArrayList<>()); | ||
| int maxCount = matchedGroup.storageInfo.getMaxAtomicMutationsCount(); | ||
|
|
||
| if (batches.isEmpty() || batches.get(batches.size() - 1).size() >= maxCount) { | ||
| // If the last batch is full or there are no batches yet, create a new batch | ||
| batches.add(new ArrayList<>()); | ||
| } | ||
|
|
||
| batches.get(batches.size() - 1).add(mutation); | ||
| } | ||
|
|
||
| // Flatten the grouped mutations into a single list of batches | ||
| return groupToBatches.values().stream().flatMap(List::stream).collect(Collectors.toList()); | ||
| } | ||
|
|
||
| private static class MutationGroup { | ||
| public final StorageInfo storageInfo; | ||
| @Nullable public final String namespace; | ||
| @Nullable public final String table; | ||
| @Nullable public final Key partitionKey; | ||
| @Nullable public final Optional<Key> clusteringKey; | ||
|
|
||
| public MutationGroup(Mutation mutation, StorageInfo storageInfo) { | ||
| assert mutation.forNamespace().isPresent() && mutation.forTable().isPresent(); | ||
|
|
||
| switch (storageInfo.getMutationAtomicityUnit()) { | ||
| case RECORD: | ||
| this.clusteringKey = mutation.getClusteringKey(); | ||
| this.partitionKey = mutation.getPartitionKey(); | ||
| this.table = mutation.forTable().get(); | ||
| this.namespace = mutation.forNamespace().get(); | ||
| this.storageInfo = storageInfo; | ||
| break; | ||
| case PARTITION: | ||
| this.clusteringKey = null; | ||
| this.partitionKey = mutation.getPartitionKey(); | ||
| this.table = mutation.forTable().get(); | ||
| this.namespace = mutation.forNamespace().get(); | ||
| this.storageInfo = storageInfo; | ||
| break; | ||
| case TABLE: | ||
| this.clusteringKey = null; | ||
| this.partitionKey = null; | ||
| this.table = mutation.forTable().get(); | ||
| this.namespace = mutation.forNamespace().get(); | ||
| this.storageInfo = storageInfo; | ||
| break; | ||
| case NAMESPACE: | ||
| this.clusteringKey = null; | ||
| this.partitionKey = null; | ||
| this.table = null; | ||
| this.namespace = mutation.forNamespace().get(); | ||
| this.storageInfo = storageInfo; | ||
| break; | ||
| case STORAGE: | ||
| this.clusteringKey = null; | ||
| this.partitionKey = null; | ||
| this.table = null; | ||
| this.namespace = null; | ||
| this.storageInfo = storageInfo; | ||
| break; | ||
| default: | ||
| throw new AssertionError( | ||
| "Unknown mutation atomicity unit: " + storageInfo.getMutationAtomicityUnit()); | ||
| } | ||
| } | ||
|
|
||
| boolean isSameGroup(Mutation otherMutation, StorageInfo otherStorageInfo) { | ||
| assert otherMutation.forNamespace().isPresent() && otherMutation.forTable().isPresent(); | ||
|
|
||
| switch (storageInfo.getMutationAtomicityUnit()) { | ||
| case RECORD: | ||
| if (!otherMutation.getClusteringKey().equals(this.clusteringKey)) { | ||
| return false; | ||
| } | ||
| // Fall through | ||
| case PARTITION: | ||
| if (!otherMutation.getPartitionKey().equals(this.partitionKey)) { | ||
| return false; | ||
| } | ||
| // Fall through | ||
| case TABLE: | ||
| if (!otherMutation.forTable().get().equals(this.table)) { | ||
| return false; | ||
| } | ||
| // Fall through | ||
| case NAMESPACE: | ||
| if (!otherMutation.forNamespace().get().equals(this.namespace)) { | ||
| return false; | ||
| } | ||
| // Fall through | ||
| case STORAGE: | ||
| if (!otherStorageInfo.getStorageName().equals(this.storageInfo.getStorageName())) { | ||
| return false; | ||
| } | ||
| break; | ||
| default: | ||
| throw new AssertionError( | ||
| "Unknown mutation atomicity unit: " + storageInfo.getMutationAtomicityUnit()); | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split the mutations for prepare-records.