Backport to branch(3) : Minor fixes to unit tests

[feeblefakie]

This is an automated backport of the following:

• Original PR: Minor fixes to unit tests #2825
• Backported commit: 9b9c4fe

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport that introduces minor but important fixes to existing unit tests. The changes primarily enhance the correctness and reliability of test assertions, addressing issues related to JUnit 5 nested class structure and the non-deterministic nature of exception suppression in concurrent execution scenarios.

Highlights

• Unit Test Structure Correction: The CoordinatorGroupCommitKeyManipulatorTest nested class within CoordinatorGroupCommitterTest.java has been changed from static to non-static. This is a common adjustment for JUnit 5 @Nested classes, often done to allow the nested class to access non-static members of the enclosing class or to ensure proper lifecycle management by the test runner. A @SuppressWarnings("ClassCanBeStatic") annotation was added to suppress compiler warnings, indicating this change is intentional.
• Robust Concurrent Exception Testing: In ParallelExecutorTest.java, the test case for executeTasks_ParallelTrueAndStopOnErrorTrue_ExceptionThrown_ShouldSt has been made more robust. Previously, it assumed a fixed order for suppressed exceptions when multiple exceptions occurred concurrently. The assertion now uses satisfiesAnyOf to correctly handle the non-deterministic order in which exceptions might be caught and suppressed, ensuring the test passes reliably regardless of the execution order.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports minor fixes to unit tests, enhancing the reliability of a parallel execution test by correctly handling the order of exceptions. A nested test class modification was also reviewed.

[gemini-code-assist]

Making CoordinatorGroupCommitKeyManipulatorTest a non-static inner class introduces an implicit reference to CoordinatorGroupCommitterTest. Unless required by the testing framework, keeping it static improves clarity.

  @Nested
  static class CoordinatorGroupCommitKeyManipulatorTest {

[gemini-code-assist]

The satisfiesAnyOf assertion can be simplified by extracting the common assertion into a separate variable to avoid redundancy and improve readability.

Suggested change

	assertThat(exception)
	.satisfiesAnyOf(
	e ->
	assertThat(e)
	.isEqualTo(executionException1)
	.hasSuppressedException(executionException2),
	e ->
	assertThat(e)
	.isEqualTo(executionException2)
	.hasSuppressedException(executionException1));
	assertThat(exception)
	.satisfiesAnyOf(
	e -> {
	assertThat(e).isEqualTo(executionException1);
	assertThat(e).hasSuppressedException(executionException2);
	},
	e -> {
	assertThat(e).isEqualTo(executionException2);
	assertThat(e).hasSuppressedException(executionException1);
	});