Backport to branch(3.16) : Fix error handling for one-phase commit

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix error handling for one-phase commit #2826
• Backported commit: 7a01959

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport aimed at improving the error handling within the one-phase commit mechanism. The core change refines the type of exception thrown when an underlying execution error occurs, transitioning from a broad CommitException to a more precise UnknownTransactionStatusException. This enhancement provides better diagnostic information and clarity regarding the transaction's state.

Highlights

• Error Handling Refinement: The onePhaseCommitRecords method in core/src/main/java/com/scalar/db/transaction/consensuscommit/CommitHandler.java has been updated. Previously, it would throw a generic CommitException when an ExecutionException occurred during a one-phase commit. Now, it throws a more specific UnknownTransactionStatusException in such cases, providing clearer error context.
• Test Suite Alignment: Corresponding test cases in core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitHandlerTest.java and core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitHandlerWithGroupCommitTest.java have been modified. These updates include changes to method signatures, test method names, and assertions to correctly reflect and verify the new UnknownTransactionStatusException being thrown.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves error handling for one-phase commits by throwing a more specific UnknownTransactionStatusException when the transaction outcome is uncertain. The changes are well-contained, and the accompanying test modifications accurately reflect the new behavior. I've identified one area for improvement in a test case to make the scenario more realistic and less confusing, which I've detailed in a specific comment. Addressing this will enhance the clarity and robustness of the test suite.

[gemini-code-assist]

The snapshot for this test is created using prepareSnapshotWithSamePartitionPut(), which includes write operations. However, commit() is called with readOnly=true. This is an inconsistent state and makes the test confusing. For a snapshot with writes, readOnly should be false. While the test currently passes due to mocking, it's better to use a realistic setup to improve clarity and ensure the test remains robust against future changes.

Suggested change

	assertThatThrownBy(() -> handler.commit(snapshot, true))
	.isInstanceOf(UnknownTransactionStatusException.class);
	assertThatThrownBy(() -> handler.commit(snapshot, false))
	.isInstanceOf(UnknownTransactionStatusException.class);