-
Notifications
You must be signed in to change notification settings - Fork 40
Backport to branch(3.16) : Add Cassandra permission test #2833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request backports a significant enhancement by introducing comprehensive permission integration tests specifically for Cassandra. It establishes a robust framework to verify that both administrative and data manipulation operations adhere to defined user permissions within a Cassandra environment, ensuring secure and controlled access to the database. This work sets up the necessary infrastructure and utilities to run these specialized tests.
Highlights
- New Permission Test Framework: I've introduced new abstract base classes,
DistributedStorageAdminPermissionIntegrationTestBaseandDistributedStoragePermissionIntegrationTestBase, to standardize permission integration testing across various distributed storage implementations. This provides a consistent structure for verifying access controls. - Cassandra-Specific Permission Tests: I've added concrete Cassandra implementations,
CassandraAdminPermissionIntegrationTestandCassandraPermissionIntegrationTest, which extend the new base classes. These provide dedicated tests to ensure Cassandra's permission model functions correctly for both administrative and data manipulation operations. Note that import-related functionalities are explicitly disabled for Cassandra as they are not supported. - Gradle Build Configuration: The
core/build.gradlefile has been updated to define a newintegrationTestCassandraPermissionsource set and a dedicated Gradle task. This allows these new permission tests to be run independently and efficiently. - Cassandra Permission Utilities: I've introduced
CassandraPermissionTestUtilsand extendedCassandraEnvto facilitate the creation, management, and permission granting for 'normal users' within Cassandra specifically for testing purposes. This includes logic for creating and dropping Cassandra roles and granting necessary permissions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports the addition of Cassandra permission tests. It includes changes to build.gradle to include and exclude the new test files, adds new test utility classes, and adds integration tests for Cassandra admin permissions. The changes also include adding properties for normal user credentials in CassandraEnv.
| System.getProperty(PROP_CASSANDRA_NORMAL_USERNAME, DEFAULT_CASSANDRA_NORMAL_USERNAME); | ||
| String password = | ||
| System.getProperty(PROP_CASSANDRA_NORMAL_PASSWORD, DEFAULT_CASSANDRA_NORMAL_PASSWORD); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider extracting the property keys PROP_CASSANDRA_NORMAL_USERNAME and PROP_CASSANDRA_NORMAL_PASSWORD into a common configuration class to avoid duplication and improve maintainability.
String username =
System.getProperty(PROP_CASSANDRA_NORMAL_USERNAME, DEFAULT_CASSANDRA_NORMAL_USERNAME);
String password =
This is an automated backport of the following:
Please merge this PR after all checks have passed.