Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a fix to the 3.16 branch that modifies error handling for mutations in Cassandra. It replaces RetriableExecutionException with ExecutionException in the BatchHandler and MutateStatementHandler classes, and updates the corresponding test cases to reflect this change. This ensures that Cassandra-related errors during mutations are handled appropriately.

Highlights

  • Error Handling: Replaces RetriableExecutionException with ExecutionException in BatchHandler to handle Cassandra-related errors during batch mutations.
  • Exception Handling: Replaces RetriableExecutionException with ExecutionException in MutateStatementHandler for handling Cassandra-related errors during mutations.
  • Test Updates: Updates test cases in BatchHandlerTest and InsertStatementHandlerTest to reflect the change from RetriableExecutionException to ExecutionException.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a backport that addresses a critical correctness issue in the Cassandra storage implementation. The main change is to stop treating WriteTimeoutException as a retriable exception for mutation operations. This is the correct approach, as a write timeout in Cassandra leaves the operation in an indeterminate state—it may or may not have been applied. Retrying could lead to data inconsistency.

The changes are consistently applied across BatchHandler and MutateStatementHandler, and the corresponding tests have been updated to reflect the new exception handling logic.

Overall, this is an excellent and important fix.

@brfrn169 brfrn169 merged commit 322c5b8 into 3.16 Jul 8, 2025
107 of 108 checks passed
@brfrn169 brfrn169 deleted the 3.16-pull-2827 branch July 8, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants