Skip to content

Conversation

@brfrn169
Copy link
Collaborator

Description

This PR is an addendum change of #2849.

Related issues and/or PRs

Changes made

  • Removed unnecessary secrets

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 requested a review from Copilot July 15, 2025 13:57
@brfrn169 brfrn169 self-assigned this Jul 15, 2025
@brfrn169 brfrn169 added improvement github_actions Pull requests that update GitHub Actions code labels Jul 15, 2025
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes old OSSRH credential secrets from the GitHub Actions workflows now that JReleaser handles authentication.

  • Deleted OSSRH_USERNAMAE and OSSRH_PASSWORD from the upload-artifacts.yaml workflow
  • Deleted OSSRH_USERNAMAE and OSSRH_PASSWORD from the release.yaml workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/upload-artifacts.yaml Remove unused OSSRH credential inputs
.github/workflows/release.yaml Remove unused OSSRH credential inputs
Comments suppressed due to low confidence (2)

.github/workflows/upload-artifacts.yaml:14

  • The environment variable 'OSSRH_USERNAMAE' appears to have a typo. It should be 'OSSRH_USERNAME' to match the common naming convention.
        required: true

.github/workflows/release.yaml:20

  • [nitpick] Since OSSRH credentials are no longer needed, please update the project documentation or README to reflect the current required secrets for JReleaser.
      SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }}

@brfrn169
Copy link
Collaborator Author

Since this is a very minor change, I'll merge this.

@brfrn169 brfrn169 merged commit 622f357 into master Jul 15, 2025
57 checks passed
@brfrn169 brfrn169 deleted the use-jreleaser-addendum branch July 15, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant