-
Notifications
You must be signed in to change notification settings - Fork 40
[addendum] Use JReleaser to release artifacts in Maven Central #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes old OSSRH credential secrets from the GitHub Actions workflows now that JReleaser handles authentication.
- Deleted
OSSRH_USERNAMAEandOSSRH_PASSWORDfrom theupload-artifacts.yamlworkflow - Deleted
OSSRH_USERNAMAEandOSSRH_PASSWORDfrom therelease.yamlworkflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/upload-artifacts.yaml | Remove unused OSSRH credential inputs |
| .github/workflows/release.yaml | Remove unused OSSRH credential inputs |
Comments suppressed due to low confidence (2)
.github/workflows/upload-artifacts.yaml:14
- The environment variable 'OSSRH_USERNAMAE' appears to have a typo. It should be 'OSSRH_USERNAME' to match the common naming convention.
required: true
.github/workflows/release.yaml:20
- [nitpick] Since OSSRH credentials are no longer needed, please update the project documentation or README to reflect the current required secrets for JReleaser.
SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }}
|
Since this is a very minor change, I'll merge this. |
Description
This PR is an addendum change of #2849.
Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A