Skip to content

Conversation

@brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 16, 2025

Description

In #2849, I forgot to pass the necessary secrets to the upload-artifacts workflow. This PR addresses the issue.

Related issues and/or PRs

Changes made

  • Updated the workflows to pass or receive the necessary secrets.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Jul 16, 2025
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@brfrn169 brfrn169 requested a review from Copilot July 16, 2025 01:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub workflow configuration to pass the correct secrets for Maven Central publishing. The change addresses a missing secrets configuration issue from a previous PR that prevented proper artifact uploading during the release process.

Key changes:

  • Replaces old signing-related secrets with Maven Central-specific secrets in the workflow interface
  • Updates the release workflow to pass the new Maven Central secrets to the upload-artifacts workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/upload-artifacts.yaml Updates the workflow interface to define Maven Central secrets instead of generic signing secrets
.github/workflows/release.yaml Updates the workflow call to pass the new Maven Central secrets to the upload-artifacts workflow

Copy link
Contributor

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 0c92980 into master Jul 16, 2025
108 of 109 checks passed
@brfrn169 brfrn169 deleted the pass-necessary-secrets-to-release-workflow branch July 16, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants