Backport to branch(3.14) : Add JDBC database permission test #2911
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request backports a significant enhancement to the JDBC storage layer by introducing a comprehensive suite of integration tests focused on database user permissions. It establishes a dedicated build configuration and new test classes to validate that ScalarDB's JDBC connector correctly enforces user privileges for both data manipulation and administrative functions across various relational database systems.
Highlights
- New JDBC Permission Integration Tests: Introduced two new integration test classes,
JdbcPermissionIntegrationTestandJdbcAdminPermissionIntegrationTest, to thoroughly verify database user permissions for both standard storage operations and administrative tasks within the JDBC storage layer. - Database User and Permission Management Utilities: Added
JdbcPermissionTestUtils, a new utility class that provides programmatic capabilities to create, drop, and grant necessary permissions to database users across various JDBC-compliant databases, including MySQL, Oracle, PostgreSQL, and SQL Server. This enables the permission tests to dynamically set up and tear down test environments. - Enhanced JDBC Environment Configuration: Modified
JdbcEnvto support the configuration and retrieval of properties for a 'normal user' (non-admin), which is essential for testing permission scenarios where different user roles are involved. - Dedicated Gradle Build Configuration: Configured the
core/build.gradlefile to create a new, isolated Gradle source set (integrationTestJdbcPermission) and a dedicatedTesttask for running these new JDBC permission integration tests. This ensures these specific tests can be run independently and efficiently.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is an automated backport to add JDBC database permission integration tests. The changes include updates to the Gradle build file to create a new test suite, and new test classes for JDBC permissions. The implementation is consistent with existing permission tests for other database backends. There is an opportunity to improve maintainability by using the Strategy Pattern in JdbcPermissionTestUtils.java.
| private String getCreateUserSql(String userName, String password) { | ||
| if (JdbcTestUtils.isMysql(rdbEngine)) { | ||
| return String.format("CREATE USER '%s'@'%%' IDENTIFIED BY '%s'", userName, password); | ||
| } else if (JdbcTestUtils.isOracle(rdbEngine)) { | ||
| return String.format("CREATE USER %s IDENTIFIED BY %s", userName, password); | ||
| } else if (JdbcTestUtils.isPostgresql(rdbEngine)) { | ||
| return String.format("CREATE USER %s WITH PASSWORD '%s'", userName, password); | ||
| } else if (JdbcTestUtils.isSqlite(rdbEngine)) { | ||
| throw new UnsupportedOperationException("SQLite does not support user management"); | ||
| } else if (JdbcTestUtils.isSqlServer(rdbEngine)) { | ||
| return String.format( | ||
| "CREATE LOGIN %s WITH PASSWORD = '%s', DEFAULT_DATABASE = master , CHECK_POLICY = OFF, CHECK_EXPIRATION = OFF; CREATE USER %s FOR LOGIN %s", | ||
| userName, password, userName, userName); | ||
| } else { | ||
| throw new UnsupportedOperationException("Creating users is not supported for " + rdbEngine); | ||
| } |
There was a problem hiding this comment.
The method getCreateUserSql uses a long if-else-if chain to select the appropriate SQL string based on the RDB engine. This pattern is repeated in getDropUserSql() and getGrantPermissionStatements(). Consider using the Strategy Pattern to move this database-specific SQL generation logic into the RdbEngineStrategy implementations. This would properly encapsulate the logic for each database, making the system easier to extend with new database types in the future.
2 participants
This is an automated backport of the following:
Please merge this PR after all checks have passed.