Skip to content

Conversation

@ymorimo
Copy link
Contributor

@ymorimo ymorimo commented Jul 30, 2025

Description

This PR removes the CR_PAT secret from all vulnerability check workflows as it is no longer required.

Related issues and/or PRs

Changes made

  • Removed CR_PAT secret requirement from vuln-check.yaml workflow
  • Removed CR_PAT secret passing from manual-vuln-check.yaml workflow
  • Removed CR_PAT secret passing from all jobs in scheduled-vuln-check.yaml workflow

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • [xI have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes

This PR depends on scalar-labs/actions#23, which must be merged first.

Release notes

Removed the CR_PAT secret from all vulnerability check workflows.

@ymorimo ymorimo self-assigned this Jul 30, 2025
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@ymorimo ymorimo marked this pull request as ready for review July 30, 2025 03:41
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 465e682 into master Jul 31, 2025
106 of 109 checks passed
@feeblefakie feeblefakie deleted the fix/remove-cr-pat-from-vuln-check branch July 31, 2025 03:15
@brfrn169 brfrn169 added github_actions Pull requests that update GitHub Actions code improvement labels Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants