Add JDBC database permission test (Part 2)

[KodaiD]

Description

This PR adds a permission test for MariaDB, YugabyteDB and Db2 under ScalarDB. To check what permissions are required for all ScalarDB operations, all DistributedStorage and DistributedStorageAdmin methods are tested. This is a final step of the permission tests project.

Related issues and/or PRs

The PRs for other permission tests:

• Add Cassandra permission test #2822
• Add DynamoDB permission test #2847
• Add JDBC database permission test #2896

Dependent bug-fix PRs:

• Fix to specify schema when creating or dropping an index with Db2 engine #2922

Changes made

• Added a new integration test for the implementations of DistributedStorage in JDBC adapter with MariaDB, YugabyteDB and Db2 engines.
• Added a new integration test for the implementations of DistributedStorageAdmin in JDBC adapter with MariaDB, YugabyteDB and Db2 engines.
• Updated a GitHub Action workflow to run the JDBC database permission tests.

Checklist

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @KodaiD, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request marks the completion of the permission testing project for ScalarDB's JDBC adapter. It introduces extensive integration tests to validate the required permissions for all DistributedStorage and DistributedStorageAdmin operations across MariaDB, YugabyteDB, and Db2, ensuring robust security and functionality for these database systems. The changes also include necessary adaptations and refinements to the test infrastructure to support these new tests.

Highlights

• New JDBC Permission Integration Tests: I've added comprehensive integration tests for the JDBC adapter's DistributedStorage and DistributedStorageAdmin methods. These tests specifically target MariaDB, YugabyteDB, and Db2 to ensure all necessary permissions for ScalarDB operations are properly verified.
• YugabyteDB DDL Synchronization: To address potential schema or catalog version mismatch errors in YugabyteDB during DDL operations, I've introduced explicit wait mechanisms (1-second sleeps) after DDL commands in the JDBC permission tests. This helps ensure consistency across test runs.
• Db2 Specific Adaptations: The JdbcPermissionTestUtils now conditionally skips user creation and dropping for Db2, as these operations are not supported via the utility for this database. Additionally, I've added specific GRANT DBADM and GRANT DATAACCESS statements for Db2 to ensure proper permission assignment. The RdbEngineDb2 implementation has also been updated to correctly handle CREATE INDEX and DROP INDEX SQL with schema inclusion.
• Test Base Class Refinements: I've generalized the DDL waiting methods in DistributedStoragePermissionIntegrationTestBase and CassandraPermissionIntegrationTest from waitForTableCreation to waitForDdlCompletion. This provides a more generic and applicable mechanism for waiting on DDL operations to complete across different database types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR adds comprehensive JDBC database permission tests for MariaDB, YugabyteDB, and Db2 engines as the final step of the permission tests project. The tests verify that all required database permissions are properly configured for ScalarDB operations by testing all DistributedStorage and DistributedStorageAdmin methods.

Key changes include:

• Integration of permission tests for three additional JDBC database engines (MariaDB, YugabyteDB, Db2)
• Enhanced test base classes with DDL completion waiting mechanisms
• Database-specific permission handling and SQL generation improvements

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
DistributedStoragePermissionIntegrationTestBase.java	Renamed method and added DDL wait call after table truncation
DistributedStorageAdminPermissionIntegrationTestBase.java	Changed column data type from TEXT to INT
RdbEngineDb2.java	Added createIndexSql method and fixed dropIndexSql to include schema
JdbcPermissionTestUtils.java	Added Db2-specific permission handling and DDL wait constant
JdbcPermissionIntegrationTest.java	Added Yugabyte-specific DDL completion waiting
JdbcAdminPermissionIntegrationTest.java	Added comprehensive DDL completion waiting for all operations
CassandraPermissionIntegrationTest.java	Updated method name to match base class change
permission-check.yaml	Added CI workflows for MariaDB, YugabyteDB, and Db2 permission testing

[gemini-code-assist]

Code Review

This pull request extends the JDBC database permission tests to include MariaDB, YugabyteDB, and Db2. The changes involve adding new integration tests, updating the test infrastructure to handle database-specific behaviors (like waits for YugabyteDB and special user management for Db2), and fixing SQL generation for Db2. The overall changes are solid, but I've identified a couple of areas with code duplication that could be refactored to improve maintainability.

[brfrn169]

LGTM! Thank you!

[komamitsu]

LGTM, thank you!

[feeblefakie]

LGTM! Thank you!

[Torch3333]

LGTM, thank you!