Backport to branch(3.16) : Remove SQL Server set up for duplicate permission tests #2969
Conversation
Co-authored-by: Hiroyuki Yamada <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated backport that removes a specific SQL Server setup script. This script was previously used to configure the database environment for duplicate permission tests. Its removal streamlines the continuous integration setup by eliminating an unnecessary component for these tests.
Highlights
- SQL Server Test Setup Script Removal: The shell script
ci/no-superuser/create-no-superuser-sqlserver.sh, which was used to configure a SQL Server instance with a non-superuser account for specific permission tests, has been completely removed from the repository.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is a backport that removes the create-no-superuser-sqlserver.sh script. This script was responsible for setting up a non-superuser for SQL Server permission tests. Based on the surrounding code, this setup is now likely handled within the Java test framework using PermissionTestUtils, which is a good practice for making tests more self-contained and maintainable. The removal of this script simplifies the CI configuration and is a positive change. The change appears correct, and I see no issues with it.
2 participants
This is an automated backport of the following:
Please merge this PR after all checks have passed.