Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport to the 3.13 branch. Its primary purpose is to remove the SQL Server setup script (create-no-superuser-sqlserver.sh) previously used for duplicate permission tests, indicating these tests or their setup are no longer required in this context.

Highlights

  • Test Infrastructure Cleanup: The ci/no-superuser/create-no-superuser-sqlserver.sh script, which was responsible for setting up SQL Server for duplicate permission tests, has been entirely removed.
  • Automated Backport: This PR is an automated backport of changes from original PR #2959, specifically committing 0faf2d9b07050e31d75a3b9494843aab5bdcb553 to the 3.13 branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a change that removes the create-no-superuser-sqlserver.sh script. This script was responsible for setting up a non-privileged user for SQL Server integration tests. As the testing strategy has been updated to use a sysadmin user for SQL Server, this script is no longer necessary. The removal is a positive change, simplifying the CI/CD pipeline and test setup. The change is correct and aligns with the new testing approach.

@KodaiD KodaiD merged commit 2822517 into 3.13 Aug 26, 2025
100 of 102 checks passed
@KodaiD KodaiD deleted the 3.13-pull-2959 branch August 26, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants