-
Notifications
You must be signed in to change notification settings - Fork 40
Backport to branch(3.15) : Enable Gradle build cache #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request backports changes to enable the Gradle build cache for improved build performance. It also includes an upgrade of the Gradle wrapper to version 8.14.3 and updates to the Gradle wrapper scripts to align with modern execution practices and licensing.
Highlights
- Enabled Gradle Build Cache: The Gradle build cache has been enabled by adding
org.gradle.caching=truetogradle.properties, which will significantly improve build performance by reusing outputs from previous builds. - Upgraded Gradle Wrapper Version: The Gradle wrapper has been upgraded from version 8.7 to 8.14.3, ensuring the project uses a more recent and potentially more stable or performant version of Gradle.
- Updated Gradle Wrapper Scripts: Both the
gradlew(Unix) andgradlew.bat(Windows) wrapper scripts have been updated to include the SPDX license identifier and to modify how the Gradle wrapper JAR is executed, transitioning to a direct-jarexecution method.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports changes to enable the Gradle build cache and upgrade the Gradle version. The changes to the Gradle wrapper scripts and properties are mostly correct and align with the goal. However, there is a critical issue with the specified Gradle version in gradle-wrapper.properties, which appears to be invalid and will likely break the build. I've left a specific comment with a suggestion to fix it.
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Gradle version 8.14.3 specified in distributionUrl appears to be invalid as it does not correspond to an official Gradle release. This will cause the build to fail with an error when trying to download the Gradle distribution.
The original commit that is being backported uses version 8.8. Please update the URL to use a valid Gradle version.
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip
This is an automated backport of the following:
Please merge this PR after all checks have passed.