-
Notifications
You must be signed in to change notification settings - Fork 40
Backport to branch(3.13) : Enable Gradle build cache #2987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This automated backport aims to enhance the project's build performance and maintainability by enabling the Gradle build cache and updating the Gradle wrapper to version 8.14.3. The changes also include necessary adjustments to the Gradle wrapper scripts (gradlew and gradlew.bat) to ensure compatibility with the updated Gradle version and to incorporate standard license identifiers.
Highlights
- Gradle Build Cache Activation: The Gradle build cache has been explicitly enabled by adding org.gradle.caching=true to a new gradle.properties file, which will significantly speed up subsequent builds by reusing outputs from previous builds.
- Gradle Wrapper Version Upgrade: The project's Gradle wrapper has been updated from version 8.7 to 8.14.3, bringing in the latest features, performance improvements, and bug fixes from the Gradle ecosystem.
- Wrapper Script Modernization: The gradlew and gradlew.bat scripts have been refined to reflect modern Gradle wrapper execution practices, including changes to classpath handling and the method of invoking the Gradle wrapper JAR, alongside the addition of SPDX license identifiers.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables the Gradle build cache and upgrades the Gradle version. The changes to the Gradle wrapper scripts (gradlew and gradlew.bat) appear to be partially incorrect. Specifically, when switching to use the -jar option for launching Java, the redundant -classpath argument was not removed. My review includes suggestions to clean this up for correctness and clarity.
| -classpath "$CLASSPATH" \ | ||
| org.gradle.wrapper.GradleWrapperMain \ | ||
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -classpath argument is ignored by the JVM when the -jar argument is used. This line is redundant and should be removed for clarity and to align with the standard Gradle wrapper script.
| -classpath "$CLASSPATH" \ | |
| org.gradle.wrapper.GradleWrapperMain \ | |
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ | |
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ |
|
|
||
| @rem Execute Gradle | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the -jar option to run a Java application, the -classpath option is ignored. This part of the command is redundant and should be removed to align with the standard Gradle wrapper script and avoid confusion.
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*
This is an automated backport of the following:
Please merge this PR after all checks have passed.