-
Notifications
You must be signed in to change notification settings - Fork 40
Backport to branch(3) : Enable Gradle build cache #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated backport aimed at enabling the Gradle build cache and updating the Gradle wrapper to version 8.14.3. These changes are intended to improve build performance by leveraging caching mechanisms and ensuring compatibility with the latest Gradle features.
Highlights
- Gradle Build Cache Activation: The build cache has been explicitly enabled by adding a configuration property in
gradle.properties. - Gradle Wrapper Upgrade: The project's Gradle wrapper has been updated from version 8.7 to 8.14.3, ensuring the use of a more recent and potentially more performant Gradle distribution.
- Wrapper Script Modernization: The
gradlewandgradlew.batscripts have been updated to align with modern Gradle wrapper execution practices, including changes to classpath handling and the method of invoking the wrapper JAR.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports the enabling of the Gradle build cache and an upgrade of the Gradle wrapper. The changes are generally good and achieve the intended purpose. I've identified a minor issue in both gradlew and gradlew.bat scripts where a redundant -classpath option is used alongside the new -jar option. While this doesn't cause a failure, removing it would improve the clarity and correctness of the scripts. I've provided suggestions to address this.
| "-Dorg.gradle.appname=$APP_BASE_NAME" \ | ||
| -classpath "$CLASSPATH" \ | ||
| org.gradle.wrapper.GradleWrapperMain \ | ||
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an automated backport of the following:
Please merge this PR after all checks have passed.