Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.util.Collections;
import java.util.Map;
import java.util.Properties;
import org.junit.jupiter.api.Disabled;

public class CassandraAdminCaseSensitivityIntegrationTest
extends DistributedStorageAdminCaseSensitivityIntegrationTestBase {
Expand All @@ -27,4 +28,12 @@ protected AdminTestUtils getAdminTestUtils(String testName) {
protected boolean isTimestampTypeSupported() {
return false;
}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.util.Collections;
import java.util.Map;
import java.util.Properties;
import org.junit.jupiter.api.Disabled;

public class CassandraAdminIntegrationTest extends DistributedStorageAdminIntegrationTestBase {
@Override
Expand All @@ -26,4 +27,12 @@ protected AdminTestUtils getAdminTestUtils(String testName) {
protected boolean isTimestampTypeSupported() {
return false;
}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

import static com.scalar.db.storage.cassandra.CassandraPermissionTestUtils.MAX_RETRY_COUNT;
import static com.scalar.db.storage.cassandra.CassandraPermissionTestUtils.SLEEP_BETWEEN_RETRIES_SECONDS;
import static org.assertj.core.api.Assertions.assertThatCode;

import com.google.common.util.concurrent.Uninterruptibles;
import com.scalar.db.api.DistributedStorageAdminPermissionIntegrationTestBase;
import com.scalar.db.exception.storage.ExecutionException;
import com.scalar.db.util.AdminTestUtils;
import com.scalar.db.util.PermissionTestUtils;
import java.util.Collections;
Expand Down Expand Up @@ -138,4 +140,17 @@ public void addRawColumnToTable_WithSufficientPermission_ShouldSucceed() {}
@Override
@Disabled("Import-related functionality is not supported in Cassandra")
public void importTable_WithSufficientPermission_ShouldSucceed() {}

@Test
@Override
public void renameColumn_WithSufficientPermission_ShouldSucceed() throws ExecutionException {
// Arrange
createNamespaceByRoot();
createTableByRoot();

// Act Assert
// Cassandra does not support renaming non-primary key columns
assertThatCode(() -> adminForNormalUser.renameColumn(NAMESPACE, TABLE, COL_NAME1, NEW_COL_NAME))
.doesNotThrowAnyException();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.util.Collections;
import java.util.Map;
import java.util.Properties;
import org.junit.jupiter.api.Disabled;

public class ConsensusCommitAdminIntegrationTestWithCassandra
extends ConsensusCommitAdminIntegrationTestBase {
Expand All @@ -27,4 +28,12 @@ protected AdminTestUtils getAdminTestUtils(String testName) {
protected boolean isTimestampTypeSupported() {
return false;
}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.util.Collections;
import java.util.Map;
import java.util.Properties;
import org.junit.jupiter.api.Disabled;

public class SingleCrudOperationTransactionAdminIntegrationTestWithCassandra
extends SingleCrudOperationTransactionAdminIntegrationTestBase {
Expand All @@ -22,4 +23,12 @@ protected Map<String, String> getCreationOptions() {
protected boolean isTimestampTypeSupported() {
return false;
}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Renaming non-primary key columns is not supported in Cassandra")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,31 @@ public void dropColumnFromTable_ForNonExistingColumn_ShouldThrowIllegalArgumentE
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForPrimaryKeyColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForIndexedColumn_ShouldDropColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_IfNotExists_ForNonExistingColumn_ShouldNotThrowAnyException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,47 @@ protected AdminTestUtils getAdminTestUtils(String testName) {
return new CosmosAdminTestUtils(getProperties(testName));
}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_DropColumnForEachExistingDataType_ShouldDropColumnsCorrectly() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForPrimaryKeyColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForIndexedColumn_ShouldDropColumnAndIndexCorrectly() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_IfExists_ForNonExistingColumn_ShouldNotThrowAnyException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,27 +23,47 @@ protected AdminTestUtils getAdminTestUtils(String testName) {
return new CosmosAdminTestUtils(getProperties(testName));
}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_DropColumnForEachExistingDataType_ShouldDropColumnsCorrectly() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForPrimaryKeyColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForIndexedColumn_ShouldDropColumnAndIndexCorrectly() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_IfExists_ForNonExistingColumn_ShouldNotThrowAnyException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,31 @@ public void dropColumnFromTable_ForNonExistingColumn_ShouldThrowIllegalArgumentE
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForPrimaryKeyColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("Cosmos DB does not support dropping columns")
@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_ForIndexedColumn_ShouldDropColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support dropping columns")
public void dropColumnFromTable_IfNotExists_ForNonExistingColumn_ShouldNotThrowAnyException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,31 @@ public void dropColumnFromTable_ForNonExistingColumn_ShouldThrowIllegalArgumentE
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_ForPrimaryKeyColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("DynamoDB does not support dropping columns")
@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_ForIndexedColumn_ShouldDropColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_IfNotExists_ForNonExistingColumn_ShouldNotThrowAnyException() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,27 +29,47 @@ protected AdminTestUtils getAdminTestUtils(String testName) {
return new DynamoAdminTestUtils(getProperties(testName));
}

@Disabled("DynamoDB does not support dropping columns")
@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_DropColumnForEachExistingDataType_ShouldDropColumnsCorrectly() {}

@Disabled("DynamoDB does not support dropping columns")
@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Disabled("DynamoDB does not support dropping columns")
@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("DynamoDB does not support dropping columns")
@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_ForPrimaryKeyColumn_ShouldThrowIllegalArgumentException() {}

@Disabled("DynamoDB does not support dropping columns")
@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_ForIndexedColumn_ShouldDropColumnAndIndexCorrectly() {}

@Disabled("DynamoDB does not support dropping columns")
@Override
@Disabled("DynamoDB does not support dropping columns")
public void dropColumnFromTable_IfExists_ForNonExistingColumn_ShouldNotThrowAnyException() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForNonExistingTable_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}

@Override
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
}
Loading