Skip to content

Backport to branch(3) : Add alter column type #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2025
Merged

Backport to branch(3) : Add alter column type #3038

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86f7748
Empty commit [skip ci]
KodaiD Oct 8, 2025
b64e4bc
Resolve conflicts
KodaiD Oct 8, 2025
7802a3b
Fix
KodaiD Oct 8, 2025
4e81dc5
Apply suggestion
KodaiD Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...st/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions .../integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
5 changes: 5 additions & 0 deletions ...on-test/java/com/scalar/db/storage/cassandra/CassandraAdminPermissionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,11 @@ public void renameColumn_WithSufficientPermission_ShouldSucceed() throws Executi
.doesNotThrowAnyException();
}

@Test
@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WithSufficientPermission_ShouldSucceed() {}

@Test
@Override
@Disabled("Cassandra does not support renaming tables")
Expand Down
13 changes: 13 additions & 0 deletions ...ava/com/scalar/db/storage/cassandra/ConsensusCommitAdminIntegrationTestWithCassandra.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...db/storage/cassandra/SingleCrudOperationTransactionAdminIntegrationTestWithCassandra.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...test/java/com/scalar/db/storage/cosmos/ConsensusCommitAdminIntegrationTestWithCosmos.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...ion-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...calar/db/storage/cosmos/SingleCrudOperationTransactionAdminIntegrationTestWithCosmos.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...ion-test/java/com/scalar/db/storage/dynamo/DynamoAdminCaseSensitivityIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
5 changes: 5 additions & 0 deletions ...egration-test/java/com/scalar/db/storage/dynamo/DynamoAdminPermissionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ public void dropColumnFromTable_WithSufficientPermission_ShouldSucceed() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_WithSufficientPermission_ShouldSucceed() {}

@Test
@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WithSufficientPermission_ShouldSucceed() {}

@Test
@Override
@Disabled("DynamoDB does not support renaming tables")
Expand Down
13 changes: 13 additions & 0 deletions ...calar/db/storage/dynamo/SingleCrudOperationTransactionAdminIntegrationTestWithDynamo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
Loading
Loading