Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This automated backport focuses on enhancing the robustness of JDBC integration tests by making the testing of TIMESTAMPTZ data types unconditional. Previously, the inclusion of TIMESTAMPTZ columns and related operations in tests was dependent on a isTimestampTypeSupported() check. This change ensures that TIMESTAMPTZ functionality is consistently verified across various admin and transaction-related scenarios, alongside minor code refactorings for cleaner test implementations.

Highlights

  • Unconditional TIMESTAMPTZ Testing: The isTimestampTypeSupported() conditional checks have been removed from various integration tests, ensuring that TIMESTAMPTZ (timestamp with time zone) columns are always included in table metadata, data insertions, and column alteration tests.
  • Refactored Test Code: Several test methods now directly assign the results of TableMetadata.newBuilder().build() and Insert.newBuilder().build() to their respective variables, simplifying the code by removing intermediate builder variables.
  • Streamlined Transaction Test Setup: In SingleCrudOperationTransactionAdminIntegrationTestWithJdbcDatabase.java, the explicit management of DistributedTransactionManager in a try-with-resources block was removed, simplifying the test setup for column type alteration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several integration tests to enable testing for the TIMESTAMPTZ data type. The changes primarily involve making the usage of TIMESTAMPTZ unconditional in JDBC-specific tests and simplifying the conditional logic around isTimestampTypeSupported() in base test classes, which improves code readability. Some tests are also refactored to use a helper method for transactional inserts, reducing code duplication. The changes are consistent and correctly implemented across all modified files. I find no issues with this pull request.

@brfrn169 brfrn169 merged commit b08c326 into 3 Oct 23, 2025
61 checks passed
@brfrn169 brfrn169 deleted the 3-pull-3079 branch October 23, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants