Backport to branch(3) : Fix to avoid deleting non ScalarDB tables when dropping namespaces

[feeblefakie]

This is an automated request for a manual backport of the following:

• Original PR: Fix to avoid deleting non ScalarDB tables when dropping namespaces #3092
• Commit to backport: 024172e

1. Resolve any conflicts that occur during the cherry-picking process.

git fetch origin &&
git checkout 3-pull-3092 &&
git cherry-pick --no-rerere-autoupdate -m1 024172e8a650f26bfc3019642932e0d3424c303b

2. Push the changes.
3. Merge this PR after all checks have passed.

Thank you!

[KodaiD]

/gemini review

[gemini-code-assist]

Code Review

This pull request backports a fix to prevent dropping namespaces that contain non-ScalarDB managed tables. The changes add the necessary checks for CosmosDB and various JDBC backends.

However, I've found a critical issue in the implementation for both CosmosAdmin and JdbcAdmin. The logic in dropNamespace is incorrect, as it doesn't first check for ScalarDB-managed tables before checking for any other tables. This can lead to incorrect error messages or behavior. I've provided suggestions to correct this logic.

Additionally, it appears that the corresponding changes for CassandraAdmin are missing from this backport. Please ensure that the Cassandra implementation is also updated to include this fix.

The rest of the changes, including updates to tests and test utilities, look good and correctly support the new functionality.

[KodaiD]

Code Review

This pull request backports a fix to prevent dropping namespaces that contain non-ScalarDB managed tables. The changes add the necessary checks for CosmosDB and various JDBC backends.

However, I've found a critical issue in the implementation for both CosmosAdmin and JdbcAdmin. The logic in dropNamespace is incorrect, as it doesn't first check for ScalarDB-managed tables before checking for any other tables. This can lead to incorrect error messages or behavior. I've provided suggestions to correct this logic.

Additionally, it appears that the corresponding changes for CassandraAdmin are missing from this backport. Please ensure that the Cassandra implementation is also updated to include this fix.

The rest of the changes, including updates to tests and test utilities, look good and correctly support the new functionality.

Incorrect. CommonDistributedStorageAdmin checks ScalarDB tables. Also, CassandraAdmin does not need the fix because CommonDistributedStorageAdmin can detect both ScalarDB tables and non-ScalarDB tables with Cassandra.