-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for administrative operations in Blob adapter #3104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
90253bc
Add Blob Storage adapter
KodaiD 71345d6
Merge branch 'master' into add-blob-adapter
KodaiD 9299df6
Refactor
KodaiD 8938ee9
Add integration tests for Wrapper
KodaiD ba7b0e9
Refactor
KodaiD a60156d
Merge branch 'master'
KodaiD d5bf8ce
Discard the unnecessary change
KodaiD e4cfa86
Fix workflow
KodaiD 02a6708
Apply suggestions
KodaiD d2fb32f
Apply suggestion
KodaiD ca8b0b6
Apply suggestions
KodaiD 6fba352
Apply suggestions
KodaiD 2b7b8e0
Refactor ObjectStorageAdmin
KodaiD 2ae5145
Fix to version metadata
KodaiD c885ff8
Apply suggestion
KodaiD ed60372
Apply suggestions
KodaiD 1c20822
Refactor BlobStorageConfigTest
KodaiD fb4ab41
Remove metadata versioning
KodaiD df628e5
Apply suggestions
KodaiD c26d52d
Merge remote-tracking branch 'origin/master' into add-blob-admin
KodaiD 4e647c7
Resolve conflicts
KodaiD 38e72c3
Apply suggestions
KodaiD 63847cc
Apply suggestions
KodaiD c1db126
Merge branch 'master' into add-blob-admin
brfrn169 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
...scalar/db/storage/objectstorage/ConsensusCommitAdminIntegrationTestWithObjectStorage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| package com.scalar.db.storage.objectstorage; | ||
|
|
||
| import com.scalar.db.transaction.consensuscommit.ConsensusCommitAdminIntegrationTestBase; | ||
| import com.scalar.db.util.AdminTestUtils; | ||
| import java.util.Properties; | ||
| import org.junit.jupiter.api.Disabled; | ||
|
|
||
| public class ConsensusCommitAdminIntegrationTestWithObjectStorage | ||
| extends ConsensusCommitAdminIntegrationTestBase { | ||
|
|
||
| @Override | ||
| protected Properties getProps(String testName) { | ||
| return ObjectStorageEnv.getProperties(testName); | ||
| } | ||
|
|
||
| @Override | ||
| protected AdminTestUtils getAdminTestUtils(String testName) { | ||
| return new ObjectStorageAdminTestUtils(getProperties(testName)); | ||
| } | ||
|
|
||
| @Override | ||
| @Disabled("Temporarily disabled because it includes DML operations") | ||
| public void truncateTable_ShouldTruncateProperly() {} | ||
|
|
||
brfrn169 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void createIndex_ForAllDataTypesWithExistingData_ShouldCreateIndexesCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void createIndex_ForNonExistingTable_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void createIndex_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void createIndex_ForAlreadyExistingIndex_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void createIndex_IfNotExists_ForAlreadyExistingIndex_ShouldNotThrowAnyException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void dropIndex_ForAllDataTypesWithExistingData_ShouldDropIndexCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void dropIndex_ForNonExistingTable_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void dropIndex_ForNonExistingIndex_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support index-related operations") | ||
| public void dropIndex_IfExists_ForNonExistingIndex_ShouldNotThrowAnyException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support dropping columns") | ||
| public void dropColumnFromTable_DropColumnForEachExistingDataType_ShouldDropColumnsCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support dropping columns") | ||
| public void dropColumnFromTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support dropping columns") | ||
| public void dropColumnFromTable_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support dropping columns") | ||
| public void dropColumnFromTable_ForPrimaryKeyColumn_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support dropping columns") | ||
| public void dropColumnFromTable_ForIndexedColumn_ShouldDropColumnAndIndexCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming columns") | ||
| public void renameColumn_ShouldRenameColumnCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming columns") | ||
| public void renameColumn_ForNonExistingTable_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming columns") | ||
| public void renameColumn_ForNonExistingColumn_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming columns") | ||
| public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming columns") | ||
| public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support altering column types") | ||
| public void | ||
| alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support altering column types") | ||
| public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support altering column types") | ||
| public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming tables") | ||
| public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming tables") | ||
| public void renameTable_ForNonExistingTable_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming tables") | ||
| public void renameTable_IfNewTableNameAlreadyExists_ShouldThrowIllegalArgumentException() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming tables") | ||
| public void renameTable_ForExistingTableWithIndexes_ShouldRenameTableAndIndexesCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("Object Storage does not support renaming tables") | ||
| public void renameTable_IfOnlyOneTableExists_ShouldRenameTableCorrectly() {} | ||
|
|
||
| @Override | ||
| @Disabled("The ScalarDB environment does not need to be upgraded with Object Storage") | ||
| public void | ||
| upgrade_WhenMetadataTableExistsButNotNamespacesTable_ShouldCreateNamespacesTableAndImportExistingNamespaces() {} | ||
| } | ||
19 changes: 19 additions & 0 deletions
19
.../db/storage/objectstorage/ConsensusCommitAdminRepairIntegrationTestWithObjectStorage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.scalar.db.storage.objectstorage; | ||
|
|
||
| import com.scalar.db.transaction.consensuscommit.ConsensusCommitAdminRepairIntegrationTestBase; | ||
| import java.util.Properties; | ||
|
|
||
| public class ConsensusCommitAdminRepairIntegrationTestWithObjectStorage | ||
| extends ConsensusCommitAdminRepairIntegrationTestBase { | ||
|
|
||
| @Override | ||
| protected Properties getProps(String testName) { | ||
| return ObjectStorageEnv.getProperties(testName); | ||
| } | ||
|
|
||
| @Override | ||
| protected void initialize(String testName) throws Exception { | ||
| super.initialize(testName); | ||
| adminTestUtils = new ObjectStorageAdminTestUtils(getProperties(testName)); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.