Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports essential changes to enable Maven publishing support for the ScalarDB Data Loader CLI module. It updates the build configuration to properly prepare and publish the CLI artifact to Maven Central, including comprehensive metadata, while specifically preventing the publication of the fat JAR. This ensures that the CLI module can be easily integrated and managed as a standard Maven dependency.

Highlights

  • Maven Publishing Enabled: The data-loader/cli module is now configured to support Maven Central publishing, allowing its artifacts to be distributed via Maven.
  • Build Plugin Update: The application plugin in data-loader/cli/build.gradle has been replaced with the maven-publish plugin to facilitate proper Maven artifact generation and publication.
  • Comprehensive POM Configuration: Detailed Project Object Model (POM) information, including artifact ID, name, description, licenses, developer contacts, and SCM details, has been added for the scalardb-data-loader-cli artifact.
  • Fat Jar Exclusion from Publication: Logic has been implemented to prevent the shadowJar (fat jar) from being published to Maven Central, ensuring that only the standard JAR artifact is made available.
  • Main Class Correction: The Main-Class attribute within the shadowJar manifest was corrected to com.scalar.db.dataloader.cli.DataLoaderCli for accurate execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Maven publishing support for the scalardb-data-loader-cli module. The changes include updating the Gradle build files to add the maven-publish plugin, configure the publication details, and integrate it into the release process. The main class in the shadow JAR manifest is also corrected. My review focuses on improving the maintainability of the Gradle build scripts. I've suggested making the logic for detecting publishing tasks more robust and refactoring the duplicated publishing configuration into a shared location to avoid redundancy. Overall, the changes correctly implement the publishing support for the CLI module.

@brfrn169 brfrn169 enabled auto-merge (squash) November 7, 2025 11:59
@brfrn169 brfrn169 disabled auto-merge November 7, 2025 12:01
@brfrn169 brfrn169 merged commit f43a9a1 into 3 Nov 7, 2025
68 of 69 checks passed
@brfrn169 brfrn169 deleted the 3-pull-3120 branch November 7, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants