Fix CoreError message parameter mismatches

[brfrn169]

Description

This PR fixes parameter count mismatches between CoreError message definitions and their buildMessage() method calls. These mismatches could cause incorrect error messages.

Related issues and/or PRs

N/A

Changes made

• Fixed parameter count mismatches between CoreError message definitions and their buildMessage() method calls.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves critical inconsistencies between CoreError message definitions and their corresponding buildMessage() method invocations. By synchronizing the expected parameter counts in error message templates with the actual arguments passed, the PR ensures that all generated error messages are complete, correctly formatted, and provide accurate contextual information, thereby preventing potential issues with misleading or incomplete error reporting across the system.

Highlights

• Error Message Definitions: Corrected parameter count mismatches in CoreError message definitions, ensuring the number of placeholders (%s) aligns with the expected arguments.
• Error Message Calls: Updated buildMessage() calls across various components (DynamoDB storage handlers and JDBC RDB engine factory) to pass the correct number of arguments, matching the revised CoreError definitions.
• Enhanced Error Detail: Improved the detail of certain error messages by adding more specific context, such as including 'Table' and 'Value' information where previously only 'Column' was specified, and adding 'Details' for JDBC connection metadata failures.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses mismatches between CoreError message definitions and their buildMessage() method calls. The changes correctly align the number of parameters in the error messages with their usage, which fixes potential IllegalFormatFlagsExceptions and improves the clarity of error messages by including more context. The modifications in CoreError.java to add more parameters to error strings are beneficial for debugging. The corresponding adjustments in BatchHandler, DeleteStatementHandler, PutStatementHandler, and RdbEngineFactory are all correct and well-implemented. Overall, this is a good set of fixes that improves code quality and robustness.

[Torch3333]

LGTM, thank you!

[komamitsu]

LGTM, thank you!

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[feeblefakie]

LGTM! Thank you!

[KodaiD]

LGTM. Thank you!