Backport to branch(3) : [RBAC] Refactor AuthAdmin RBAC interfaces to eliminate confusion

[feeblefakie]

This is an automated backport of the following:

• Original PR: [RBAC] Refactor AuthAdmin RBAC interfaces to eliminate confusion #3142
• Backported commit: 9fff185

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport that refactors the Role-Based Access Control (RBAC) interfaces within the AuthAdmin component. The primary goal of these changes is to enhance the clarity and reduce potential confusion in the API by introducing more descriptive and semantically precise interface names and structures for managing roles, user-role assignments, and role hierarchies. This ultimately improves the maintainability and usability of the authentication administration functionalities.

Highlights

• Interface Renaming: The RoleDetail interface has been renamed to Role, and UserRoleDetail has been renamed to RoleForUser to provide clearer semantics.
• New Reference Interfaces: New interfaces, GrantedRoleRef and GranteeUserRef, have been introduced to explicitly represent references to granted roles and grantee users, respectively, replacing the previous UserRole and RoleHierarchy interfaces.
• Method Signature Updates: Method signatures in AuthAdmin and DecoratedDistributedTransactionAdmin have been updated to reflect the new interface names, ensuring consistency across the API.
• Javadoc Enhancements: Javadoc comments have been added or updated for various methods within the User and Role interfaces to improve documentation and understanding.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the RBAC interfaces in AuthAdmin to improve clarity and eliminate confusion, as stated in the title. The new interface names like RoleForUser, GranteeUserRef, and GrantedRoleRef are more descriptive than their predecessors. The restructuring, such as embedding granted roles within the Role interface, leads to a more object-oriented and intuitive design. The changes are consistently applied across the modified files. I have one minor suggestion to improve the documentation's consistency with the new terminology.