Backport to branch(3) : Disable negative cache for table metadata

[feeblefakie]

This is an automated backport of the following:

• Original PR: Disable negative cache for table metadata #3182
• Backported commit: 72b2c7d

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a change that refactors the table metadata caching layer. It transitions from using Guava Cache to Caffeine, a more modern and performant caching library. A significant aspect of this change is the explicit disabling of negative caching for table metadata, meaning that requests for non-existent tables will no longer have their 'not found' status cached, ensuring fresh lookups against the storage backend for such cases.

Highlights

• Cache Library Migration: The internal caching mechanism for table metadata has been migrated from Google Guava Cache to Caffeine, a high-performance caching library for Java. This involves updating build dependencies and refactoring cache initialization.
• Negative Cache Disablement: The system no longer caches the absence of table metadata (i.e., 'negative caching'). If a table is not found, null is returned, and this null value is not stored in the cache, ensuring that subsequent requests for non-existent tables will always query the underlying storage.
• Improved Exception Handling: The exception handling logic for cache loading has been updated to correctly unwrap CompletionException and expose the root cause, providing clearer error reporting when an underlying storage operation fails.
• Test Enhancements: New test cases have been added and existing ones modified to validate the new caching behavior, particularly for scenarios where table metadata is not found and to ensure proper exception propagation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively disables negative caching for table metadata by migrating from Guava Cache to Caffeine. The core change involves moving away from caching Optional<TableMetadata> to caching TableMetadata directly, and leveraging Caffeine's default behavior of not caching null values returned by the loader. This prevents caching of non-existent table metadata. The implementation is clean, utilizing lambdas for more concise cache loader definitions and correctly updating exception handling to manage Caffeine's CompletionException. The accompanying tests are thorough, verifying that negative lookups are not cached and that exceptions are propagated correctly. Overall, the changes are well-executed and improve the caching behavior as intended.