Backport to branch(3.16) : Fix exception handling in the data loader importing to handle the unkown exceptions properly

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix exception handling in the data loader importing to handle the unkown exceptions properly #3183
• Backported commit: fd37bca

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a critical fix to the data loader's ImportProcessor to significantly enhance its exception handling capabilities. The primary goal is to ensure that the data loader can gracefully manage both expected TransactionException and unexpected runtime exceptions that may occur during the transaction processing of data batches. This improvement makes the data import process more resilient and provides clearer, more detailed error reporting, ultimately leading to a more stable and reliable data loading mechanism.

Highlights

• Enhanced Exception Handling: The ImportProcessor now includes a general catch (Exception e) block to properly handle unexpected runtime exceptions that may occur during transaction processing, preventing unhandled crashes and improving resilience.
• Centralized Transaction Abort Logic: A new private helper method, abortTransactionSafely, has been introduced to encapsulate the logic for safely aborting distributed transactions, improving code reusability and robustness by handling null transactions and logging abort exceptions.
• Improved Error Logging: Error messages for both TransactionException and general Exception now include more contextual information, such as transactionBatchId and dataChunkId, which will aid significantly in debugging.
• New Test Coverage: A new unit test, process_withUnexpectedExceptionInTransaction_shouldHandleGracefully, has been added to verify the correct behavior of the ImportProcessor when an unexpected exception occurs during transaction initiation, ensuring the new handling works as intended.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports a fix to improve exception handling in the data loader. The changes introduce a new catch block to handle unexpected exceptions during transaction processing, preventing them from crashing the import process. The transaction abort logic has also been refactored into a new abortTransactionSafely method for better code reuse and clarity. A corresponding unit test has been added to verify the new behavior. The changes are well-implemented and enhance the robustness of the data loader. I have one suggestion to improve the error message formatting for unexpected exceptions.