Backport to branch(3) : Add early validation for transaction mode compatibility in the data loader import command

[feeblefakie]

This is an automated backport of the following:

• Original PR: Add early validation for transaction mode compatibility in the data loader import command #3186
• Backported commit: 0f200ff

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a critical enhancement to the data loader's import command, introducing proactive validation for transaction mode compatibility. This change ensures that the data loader can gracefully handle scenarios where it's configured for TRANSACTION mode but the underlying ScalarDB setup does not support distributed transactions, preventing unexpected runtime errors and providing clearer feedback to users.

Highlights

• Early Transaction Mode Validation: Implemented a new validation step in the data loader's import command to check for transaction mode compatibility, preventing runtime errors due to misconfiguration.
• Improved Error Handling: Introduced specific error messages (INVALID_TRANSACTION_MODE, TRANSACTION_MODE_VALIDATION_FAILED) for misconfigurations related to transaction mode, providing clearer feedback to users.
• Refactored Dependency Injection: Modified createTableMetadataMap and createImportManager methods to accept TransactionFactory as a parameter, improving modularity and testability.
• Enhanced Test Coverage: Added new unit tests to ensure the robustness of the transaction mode validation logic, covering cases of unsupported operations and other exceptions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports an early validation check for transaction mode compatibility in the data loader's import command. The changes are well-implemented, introducing a validateTransactionMode method that fails fast if the configuration is incorrect. This improves user experience by providing immediate and clear feedback. The associated refactoring to create the TransactionFactory only once and pass it down to dependent methods is a good improvement for efficiency and code clarity. The new unit tests effectively cover the failure scenarios for the validation logic. I have a couple of minor suggestions to further improve code correctness and maintainability.