Backport to branch(3) : Improve ExecutorService lifecycle handling by moving shutdown to finally block

[feeblefakie]

This is an automated backport of the following:

• Original PR: Improve ExecutorService lifecycle handling by moving shutdown to finally block #3166
• Backported commit: 4cfac72

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports critical improvements to the data export functionality, primarily focusing on robust resource management. It refines the lifecycle handling of ExecutorService and BufferedWriter to ensure proper termination and closure under all circumstances, including error conditions. These changes enhance the stability and reliability of the export process by preventing resource leaks and ensuring consistent behavior.

Highlights

• Resource Management: The BufferedWriter is now initialized within a try-with-resources statement, ensuring its automatic and proper closure, even if exceptions occur during the export process.
• ExecutorService Lifecycle: The ExecutorService shutdown logic has been moved into a finally block. This guarantees that the service is always terminated, using shutdownNow() as a fallback if graceful shutdown is not reached or fails, preventing potential resource leaks.
• Export Footer Processing: The processFooter method is now invoked only after all tasks submitted to the ExecutorService have successfully completed their execution, ensuring the footer is written only when the export is fully successful.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves resource management by moving the BufferedWriter into a try-with-resources block and attempting to ensure the ExecutorService is always shut down. While these are positive changes, the implementation for the ExecutorService shutdown is incomplete and can still lead to resource leaks in certain failure scenarios. I've added a critical review comment explaining the issue and suggesting the correct pattern to ensure the thread pool is always terminated, preventing potential leaks.