Backport to branch(3) : Enable negative cache in VirtualTableInfoManager to improve performance

[feeblefakie]

This is an automated backport of the following:

• Original PR: Enable negative cache in VirtualTableInfoManager to improve performance #3209
• Backported commit: 709b5a7

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a crucial performance enhancement to the VirtualTableInfoManager. By modifying the caching mechanism to store Optional values, the system can now effectively cache the information that a particular virtual table does not exist. This 'negative caching' capability significantly reduces the number of redundant calls to the underlying storage administration service, thereby optimizing performance, especially in scenarios where queries for non-existent tables are frequent.

Highlights

• Negative Caching Implemented: The VirtualTableInfoManager now utilizes negative caching by storing Optional<VirtualTableInfo> in its cache. This allows the system to cache the absence of a virtual table.
• Performance Improvement: This change prevents repeated calls to the DistributedStorageAdmin for virtual tables that do not exist, leading to improved performance by reducing redundant lookups.
• Test Case Update: An existing test case was updated to reflect and verify the new negative caching behavior, ensuring that Optional.empty() results are correctly cached.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables negative caching in VirtualTableInfoManager to improve performance by caching Optional.empty() for non-existent virtual tables. The changes in VirtualTableInfoManager and the corresponding test file are logical and correctly implement the intended optimization. I have one suggestion to enhance the robustness of the error handling, which will prevent a potential NullPointerException in production environments.