Skip to content

Extend applicability of one-phase commit optimization in Consensus Commit #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Extend applicability of one-phase commit optimization in Consensus Commit #3219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed305ae
Extend applicability of one-phase commit optimization
brfrn169 Nov 16, 2025
0e6538e
Fix
brfrn169 Nov 25, 2025
5af5b35
Merge branch 'master' into extend-applicability-of-one-phase-commit-o…
brfrn169 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
482 changes: 447 additions & 35 deletions core/src/main/java/com/scalar/db/transaction/consensuscommit/CommitHandler.java
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions ...src/main/java/com/scalar/db/transaction/consensuscommit/CommitHandlerWithGroupCommit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ public void commit(TransactionContext context)
}

@Override
boolean canOnePhaseCommit(TransactionContext context) throws CommitException {
boolean canOnePhaseCommit(ValidationInfo validationInfo, TransactionContext context)
throws CommitException {
try {
return super.canOnePhaseCommit(context);
return super.canOnePhaseCommit(validationInfo, context);
} catch (CommitException e) {
cancelGroupCommitIfNeeded(context.transactionId);
throw e;
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ DistributedTransaction begin(
"Setting different isolation level from the one in DatabaseConfig might cause unexpected "
+ "anomalies");
}
Snapshot snapshot = new Snapshot(txId, isolation, tableMetadataManager, parallelExecutor);
Snapshot snapshot = new Snapshot(txId, tableMetadataManager);
TransactionContext context =
new TransactionContext(txId, snapshot, isolation, readOnly, oneOperation);
DistributedTransaction transaction =
Expand Down
Loading