-
Notifications
You must be signed in to change notification settings - Fork 40
Update Scheduled Vulnerability Check and Dependabot configuration #3229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Scheduled Vulnerability Check and Dependabot configuration #3229
Conversation
Summary of ChangesHello @brfrn169, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request ensures that the project's automated dependency and vulnerability scanning mechanisms are correctly configured for the latest ScalarDB 3.17 release cycle. By updating the Dependabot settings, the project maintains its ability to automatically track and update dependencies across its various active branches, contributing to ongoing security and maintenance. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Dependabot configuration to target new branches, including the new 3.17 release branch. The changes are straightforward and correct. I've identified a small opportunity to improve maintainability by removing redundant information in the group names for GitHub Actions, which would make future updates less error-prone. I've provided a suggestion for this improvement.
| target-branch: "3.17" | ||
| groups: | ||
| actions on branch 3.16: | ||
| actions on branch 3.17: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The group name actions on branch 3.17 is coupled with the target-branch on line 48. This duplication can lead to inconsistencies in the future if the branch is updated in one place but not the other. To improve maintainability and reduce the chance of error, consider using a more generic group name that doesn't include the branch version. This suggestion applies to all similar github-actions configurations in this file.
github-actions:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
This PR updates the Scheduled Vulnerability Check and Dependabot configuration for the ScalarDB 3.17 release.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A