Skip to content

Conversation

@jnmt
Copy link
Collaborator

@jnmt jnmt commented Jul 24, 2025

Description

The ScalarDB team faced an OOM error when publishing artifacts to Maven Central using the jreleaserDeploy task (scalar-labs/scalardb#2877). Although we haven't yet for ScalarDL, this PR prevents it by increasing the heap size allocated to the jreleaserDeploy task.

Related issues and/or PRs

Changes made

  • Increased the heap size for the jreleaserDeploy task.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@jnmt jnmt requested review from choplin, Copilot and feeblefakie July 24, 2025 00:46
@jnmt jnmt self-assigned this Jul 24, 2025
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the heap size allocated to the jreleaserDeploy Gradle task to prevent OutOfMemoryError exceptions during Maven Central artifact publishing, addressing an issue encountered by the ScalarDB team.

  • Adds JVM arguments to set maximum heap size to 4GB for jreleaserDeploy task
  • Applied consistently across both release and snapshot release workflows

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yaml Increases heap size for jreleaserDeploy task in main release workflow
.github/workflows/release-snapshot.yaml Increases heap size for jreleaserDeploy task in snapshot release workflow

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link

@choplin choplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants