-
Notifications
You must be signed in to change notification settings - Fork 3
Increase heap size for jreleaserDeploy task #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR increases the heap size allocated to the jreleaserDeploy Gradle task to prevent OutOfMemoryError exceptions during Maven Central artifact publishing, addressing an issue encountered by the ScalarDB team.
- Adds JVM arguments to set maximum heap size to 4GB for jreleaserDeploy task
- Applied consistently across both release and snapshot release workflows
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yaml | Increases heap size for jreleaserDeploy task in main release workflow |
| .github/workflows/release-snapshot.yaml | Increases heap size for jreleaserDeploy task in snapshot release workflow |
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
choplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
The ScalarDB team faced an OOM error when publishing artifacts to Maven Central using the jreleaserDeploy task (scalar-labs/scalardb#2877). Although we haven't yet for ScalarDL, this PR prevents it by increasing the heap size allocated to the jreleaserDeploy task.
Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A