This repository was archived by the owner on Nov 28, 2019. It is now read-only.
Refine Exceptions for Selector and SelectionKey#101
Open
jczuchnowski wants to merge 3 commits intoscalaz:masterfrom
Open
Refine Exceptions for Selector and SelectionKey#101jczuchnowski wants to merge 3 commits intoscalaz:masterfrom
jczuchnowski wants to merge 3 commits intoscalaz:masterfrom
Conversation
jczuchnowski
force-pushed
the
selection-key-exceptions
branch
from
bc542a8 to
69d71e3
Compare
pshemass
reviewed
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's hard to say if
ClosedSelectorExceptionandCancelledKeyExceptionare something user can recover from but I think we should be explicit about this API behavior.