-
Notifications
You must be signed in to change notification settings - Fork 67
Make model-engine FIPS compliant by updating base chainguard image #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ValentineDragan
merged 31 commits into
main
from
fix/fix-vulnerabilities-in-model-engine-image
Nov 3, 2025
Merged
Changes from 28 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
cf6c084
Update Dockerfile
ValentineDragan 0201f0c
Update circleci config to login to chainguard
ValentineDragan 8ece2a5
fix typo in circleci config
ValentineDragan c3ef4e5
Add code to debug circleci errors
ValentineDragan 93f579a
Debug missing chainguard token
ValentineDragan 3853517
Debug failing oidc token swap
ValentineDragan 9dac2cd
Update config
ValentineDragan 8104ff1
Retry OIDC token swap with updated chainguard identity
ValentineDragan 4ddee82
Update audience for token exchange request
ValentineDragan e5642e8
Simplify chainguard authentication with chainctl
ValentineDragan 44b59ed
Specify audience cgr.dev in auth login
ValentineDragan 82fe322
Update system packages in Dockerfile
ValentineDragan 209a34a
Update Dockerfile packages for chainguard compatbility
ValentineDragan 6f79179
update Dockerfile
ValentineDragan ae1bb4e
Revert circleci python version to 3.10.14
ValentineDragan a465e51
Update hardcoded model-engine image tag used in integration tests
ValentineDragan 0eca9cb
Fix CircleCI config trying to use hardcoded model-engine image tag fo…
ValentineDragan fe8d764
Mount service_config_circleci.yaml in batch job pods
ValentineDragan b53b7c9
Fix broken helm template
ValentineDragan b054e67
Add missing infra config and service template config to batch job pods
ValentineDragan c142b27
remove redundant config for batch job pods
ValentineDragan f312dfe
enable SHA256 checksums for Celery S3 backend to avoid MD5 decoding i…
ValentineDragan f742965
Fix failing md5 monkey patch
ValentineDragan c8a2c66
bump sqlalchemy to 2.0.21 to address md5 FIPS compliance
ValentineDragan 5e4fcf2
Fix black linting errors
ValentineDragan 506b0bf
wrap Dockerfile layers between root and nonroot user
ValentineDragan 66cbd33
Remove the federal/ directory since Dockerfile is now FIPS compliant …
ValentineDragan e27a32d
set celery_enable_sha256 to true in all configs for FIPS compliance
ValentineDragan fb479f6
make changes backwards compatible by having separate Dockerfiles
ValentineDragan 9b11f29
formatting
ValentineDragan aec1fe0
Merge branch 'main' into fix/fix-vulnerabilities-in-model-engine-image
ValentineDragan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious if you needed to add this for specific reason? do you actually use
batch-job-orchestration-jobThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if we don't add this change, there are integration tests running batch jobs that will fail because they can't find the service configs. See explanation below:
This is part of fixing the integration tests bug in the file below (rest_api_utils.py). Context (I debugged all this by SSH-ing into the instance running the CircleCI workflows and inspecting the kubernetes logs):
830c81ecba2a147022e504917c6ce18b00c2af44) to run - seeCREATE_DOCKER_IMAGE_BATCH_JOB_BUNDLE_REQUEST,CREATE_FINE_TUNE_DI_BATCH_JOB_BUNDLE_REQUEST..rest_api_utils.pyfile to rebuild the container.Fixing this bug caused the integration tests to fail because the old hardcoded image had the service configs copied inside the container image, whereas new images need to mount them instead. I reran these tests on another branch where I only changed the model engine image tag used to confirm this is an isolated issue - no other changes (i.e. Dockerfile):