-
Notifications
You must be signed in to change notification settings - Fork 0
Pass-through header forwarding with server-side exclusions #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Instead of doing for the ACP. This is because we likely may need to also pass in additional items as well to this and we shouldn't have it expand at the top level too far. |
jasonyang101
reviewed
Sep 4, 2025
jasonyang101
reviewed
Sep 4, 2025
jasonyang101
reviewed
Sep 4, 2025
af44d2a to
7dabcd4
Compare
f9ac098 to
a3f03f8
Compare
a3f03f8 to
ac0d339
Compare
807f155 to
c7731c8
Compare
c7731c8 to
f16d53c
Compare
smoreinis
reviewed
Sep 9, 2025
smoreinis
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Updated from Security-by-default to pass-through-by-default
This PR enables pass-through by default forwarding of HTTP headers from applications to agents. Sensitive and hop by hop headers are excluded at the FastACP server boundary. Agents receive headers via the unified request object without additional setup.
What changed
Why
This supports OAuth tokens, tenant context, tracing and role metadata with minimal configuration. Exclusions protect agent API key and noisy transport headers while keeping the model simple.
Tests
If an agent needs tighter rules it can filter inside its handler. This keeps the core path simple and fast.