Move lb frontend port definition from ScalewayCluster to Cluster #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomy2e
requested changes
Aug 21, 2025
Member
Tomy2e
left a comment
Tomy2e
left a comment
There was a problem hiding this comment.
Can you add or update the existing e2e tests to use a custom frontend port?
damsien
force-pushed
the
main
branch
2 times, most recently
from
2d45d48 to
b834f5a
Compare
Tomy2e
requested changes
Aug 26, 2025
Signed-off-by: Damien DASSIEU <[email protected]>
Tomy2e
changed the title
Tomy2e
approved these changes
Aug 26, 2025
damsien
added a commit
that referenced
this pull request
Aug 26, 2025
#30) Move lb port definition from ScalewayCluster to Cluster Signed-off-by: Damien DASSIEU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to use the
APIServerPortfield from theClusterobject instead of the previousPortfromScalewayClusterobject to configure the LB exposing the kube-apiserver .