Skip to content

Conversation

@QuentinCG
Copy link
Contributor

@QuentinCG QuentinCG commented Nov 3, 2024

Your checklist for this pull request

Description

Adding example for Linux in https://www.scaleway.com/en/docs/dedibox/dedicated-servers/how-to/use-dedibackup-ftp-backup/ to help user understand how to use the FTP backup server.

Indeed, this FTP server is a bit 'limited' as some basic commands like curl is not working properly with it.
It is therefor quite useful to have a working example (even if basic).

@QuentinCG QuentinCG requested a review from bene2k1 as a code owner November 3, 2024 16:35
@bene2k1 bene2k1 added the status: tech review Waiting for technical review label Nov 4, 2024
@bene2k1 bene2k1 added status: doc review Waiting for doc team review and removed status: tech review Waiting for technical review labels Nov 6, 2024
@bene2k1
Copy link
Member

bene2k1 commented Nov 6, 2024

Hello @QuentinCG,

Thank you for submitting your PR!
Our engineering team has reviewed it, and we’ve provided some feedback and suggestions to help improve the Dedibackup documentation.

Feel free to apply these changes as you see fit, and don’t hesitate to reach out if you have any questions or would like to discuss any of the points further.

Benedikt

@QuentinCG
Copy link
Contributor Author

Hello @bene2k1
Thanks for the review suggestion.

I agreed on all of them (better English explanation & more suitable example and limitation explanation).

@bene2k1
Copy link
Member

bene2k1 commented Nov 8, 2024

Hello @QuentinCG,

Thank you for applying the suggestions.
Your PR has been reviewed by the documentation team and accepted to be merged.

The updated documentation will be published very soon.

Benedikt

@bene2k1 bene2k1 merged commit 81f8b22 into scaleway:main Nov 8, 2024
Laure-di pushed a commit to Laure-di/docs-content that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: doc review Waiting for doc team review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants