docs(faq): use productIcon from UV instead of static assets #3995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoRoJ
approved these changes
Nov 19, 2024
jcirinosclwy
approved these changes
Nov 19, 2024
Laure-di
pushed a commit
to Laure-di/docs-content
that referenced
this pull request
Mar 11, 2025
…#3995) * docs(faq): use productIcon from UV instead of static assets * feat: update documentation of component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Description
This PR update content of FAQ pages in order to remove hardcoded productIcon logo.
Currently productIcon are not synchronised with UV designs.
FAQ pages import a static asset which is directly added in the repository here.
In order to change that, here is a proposition where Docs team only have to put the productIcon name from UV and it will automatically load it.
Here is the list of available icons https://storybook.ultraviolet.scaleway.com/index.html?path=/docs/icons-producticon--docs#list
Don't merge it, it needs to be merge in sync with docs website code.